Extract DispatchEngine and slim Router to a route registry#166
Merged
alganet merged 1 commit intoRespect:masterfrom Mar 17, 2026
Merged
Extract DispatchEngine and slim Router to a route registry#166alganet merged 1 commit intoRespect:masterfrom
alganet merged 1 commit intoRespect:masterfrom
Conversation
Move the request execution algorithm out of Router into a dedicated DispatchEngine so the router can focus on route definition and registry concerns. Changes: - add DispatchEngine to own dispatch lifecycle logic: routeless handling, method override resolution, virtual-host path adjustment, route matching, routine matching, OPTIONS handling, and Allow/404/400/405 materialization - make Router delegate dispatch(), dispatchContext(), and run() to the engine instead of performing request execution itself - keep Router focused on route registration, route sorting, global routine attachment, and convenience entry points - add small Router accessors needed by the engine for route registry and virtual-host lookup - update low-level router tests and coverage annotations to reflect the new engine boundary Verification: - composer qa - changed executable lines verified at 100% coverage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
============================================
- Coverage 97.14% 96.89% -0.25%
- Complexity 445 450 +5
============================================
Files 27 28 +1
Lines 1085 1096 +11
============================================
+ Hits 1054 1062 +8
- Misses 31 34 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the request execution algorithm out of Router into a dedicated DispatchEngine so the router can focus on route definition and registry concerns.
Changes:
Verification: