Extract staged routine execution into RoutinePipeline#167
Merged
Conversation
Formalize the when/by/through lifecycle behind a dedicated pipeline so routine orchestration no longer lives in scattered route and context methods. Changes: - add RoutinePipeline to own: - when-stage route gating - by-stage pre-handler routine execution - through-stage post-handler transformation - make DispatchEngine use RoutinePipeline for match-time routine checks - make DispatchContext use the pipeline for pre/post route execution - remove routine-stage orchestration from DispatchContext - remove AbstractRoute::matchRoutines() now that when-stage execution is owned by the pipeline - keep forwarding, response short-circuiting, and through-transform behavior intact under the new staged abstraction Verification: - composer qa - changed executable lines verified at 100% coverage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
============================================
- Coverage 96.89% 96.88% -0.01%
- Complexity 450 452 +2
============================================
Files 28 29 +1
Lines 1096 1093 -3
============================================
- Hits 1062 1059 -3
Misses 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formalize the when/by/through lifecycle behind a dedicated pipeline so routine orchestration no longer lives in scattered route and context methods.
Changes:
Verification: