Sidebar settings and features discoverability#474
Conversation
|
@Rosy-iso this seems like a ui change, so yours to review :3 |
Rosy-iso
left a comment
Rosy-iso
left a comment
There was a problem hiding this comment.
Hm, this one is a tough one.
The idea in itself is a nice one, can help newer users...but
First of all, I don't think I've seen other popup menus have toggles before...but there's always a first time and I think it's been implemented fine here (using the bigger switch would be too cumbersome anyway)
But the button to access this menu...that i'm really unsure about...
First of all the three dots are rotated 90° compared to all other thee dots buttons (unless I missed any), which I feel like should be changed for Consistency, but other than that...it's complicated: its a tiny borderless button which is consistent with all other three dots button but is inconsistent with the other buttons in the sidebar..but that's fine since this is a smaller menu with less of a scope, it fits to be smaller...but it still occupies a decent amount of space for something that most of the time you do only need to click once and barely ever again.
To summarize my ramblings, maybe the button needs a bit more purpose to justify its presence? It does seem to essentially take up an entire "slot" so it is substantial imo, but I'm willing to discuss all this
Overall, still def a good and promising idea I believe
|
@Rosy-iso Hm, I will remove this button for now and leave the options as a right click context menu. If some more features come up that could be put in there, we could then go back to the button. |
|
Maybe it can be context aware? Like right clicking on the sidebar but then again how would you handle it on mobile |
I assume long press? Does the app actually translate the touch-and-hold events to right-click at the moment, or are all context menus non functional on mobile? |
Nothing is translated, context menus are non-functional unless they have a specific mobile implementation |
|
I have moved these quick settings to live in a context menu activated with a right mouse click. |
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * `Ctrl + K` search menu is now context aware and lists the current space's rooms at the top. ([#499](#499) by @7w1) * Add knocking support when attempting to join a room from the directory, an address, a room mention, or space hierarchy, as well as text command support for knocking. Also improves rendering for knock notifications in rooms. ([#470](#470) by @polyjitter) * Add Android/iOS PWA-specific icon variants. ([#473](#473) by @Septicity) * Add support for youtube embeds. ([#497](#497) by @thundertheidiot) * Add sidebar three dot menu for quick access to related settings ([#474](#474) by @wolterkam) * Replies that mention the OP are now indicated by the OP username being prefixed with @ ([#465](#465) by @mini-bomba) * Made pin events show a tally of the messages that are pinned. ([#462](#462) by @nushea) ### Improve multiline composer and voice recording ([#476](#476) by @hazre) - Add a multiline composer layout for longer drafts. - Keep the voice recorder between composer actions in multiline mode. - Show the recorder inside the composer on mobile while recording. - Prevent the composer from expanding when recording starts. - Make the recorder footer and waveform fit better across screen sizes. - Let interrupted mobile recording gestures still stop correctly. - Stabilize wrap detection around edge cases like narrow widths and trailing spaces. ## Fixes * Added error messages provided by homeserver to unknown login errors. ([#496](#496) by @7w1) * Ensure new updates always reload the page properly. ([#502](#502) by @7w1) * Removed the blocked users moved notice from notifications setting page. ([#490](#490) by @7w1) * Fix recieved encrypted message per-message profiles not triggering rerenders. ([#464](#464) by @7w1) * Add `.m4a` files as a recognized audio type. ([#472](#472) by @henk717) * Fix messages disappearing from rooms after reconnects and timeline resets. ([#478](#478) by @hazre) * Fix Camera being enabled by default even when the client has it off pre joining in browsers that permit the video (Electron/Tauri as examples). ([#485](#485) by @Rawrington) * Fix cinny-dark-theme link colors being too dark ([#469](#469) by @Elec3137) * Fix "Default" menu item height in room notification switcher. ([#466](#466) by @polyjitter) * fix the issue of empty displaynames of a persona, causing an empty fallback message, it will now ommit the fallback, if the name is empty or only consists of whitespace ([#495](#495) by @dozro) * Fixed an Android issue where recording a voice message with headphones could leave audio stuck in low-quality mode until the app was restarted. ([#476](#476) by @hazre) * Fixed voice message scrubbing/seeking on Firefox by switching the recorder from WebM (no seek index) to Ogg/Opus. ([#476](#476) by @hazre) * fixes touchpad zooming behaviour ([#481](#481) by @integralfunction) * Fixes width mismatch for the call chat view. ([#460](#460) by @polyjitter) * Fix messages sent from sable showing wrong on other client(s) ([#468](#468) by @nushea) ## Documentation * Updated PR template and CONTRIBUTING.md to add AI disclosure requirement. ([#456](#456) by @Rosy-iso)
5 participants
Description
Improves discoverability of settings and features related to Sidebar. Somewhat related to #391.
Fixes #
Type of change
Checklist: