Skip to content

fix: unify sidebar count badge positioning#484

Open
hazre wants to merge 2 commits intodevfrom
hazre/fix/sidebar-count-badge-positioning
Open

fix: unify sidebar count badge positioning#484
hazre wants to merge 2 commits intodevfrom
hazre/fix/sidebar-count-badge-positioning

Conversation

@hazre
Copy link
Member

@hazre hazre commented Mar 22, 2026

Description

Fixes the misaligned of badges and unifies the code under a single component. AI was used to create the unit test and do the mass change to the new component work.

Screenshots

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@hazre hazre requested a review from 7w1 as a code owner March 22, 2026 23:02
@hazre hazre added the ui change this pr introduces ui changes label Mar 22, 2026
@github-actions
Copy link
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-484-sable.raspy-dream-bb1d.workers.dev 75d7707 pr-484 Sun, 22 Mar 2026 23:08:04 GMT

@7w1
Copy link
Member

7w1 commented Mar 23, 2026

Doesn't this ignore the show unread counts setting?

Edit: Wait what i didn't approve these changes github is gaslighting me

Copy link
Member

@7w1 7w1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

respect unread counts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui change this pr introduces ui changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants