feat: Credits & Provenance — the people behind the music#219
Merged
SimplicityGuy merged 5 commits intomainfrom Mar 27, 2026
Merged
feat: Credits & Provenance — the people behind the music#219SimplicityGuy merged 5 commits intomainfrom
SimplicityGuy merged 5 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Surface credited personnel (producers, engineers, mastering engineers, session musicians, designers) as first-class graph entities with queryable API endpoints and an interactive Explore UI pane. - Add Person node type with CREDITED_ON and SAME_AS relationships - Extract extraartists from Discogs release data in normalizer - Create role taxonomy (production/engineering/mastering/session/design/management) - Extend graphinator and batch processor for credits ingestion - Add 8 API endpoints: person credits, timeline, profile, release credits, role leaderboard, shared credits, connections graph, autocomplete - Add Credits pane to Explore UI with search, profile card, timeline chart, release list, D3.js connections graph, and leaderboard - Add Neo4j schema: Person constraint, credit_count index, fulltext index - Add comprehensive tests (33 API + 28 taxonomy + 5 normalizer + graphinator) https://claude.ai/code/session_01NomEjsUFJNWeFJpZaifDNU
- Fix Semgrep XSS findings: replace all innerHTML usage in credits.js with safe DOM APIs (createElement, textContent, appendChild) - Remove unused _escapeHtml helper (no longer needed) - Add test coverage for Redis caching paths in credits router (cache hit, cache miss/set, cache error fallthrough for both person_credits and role_leaderboard endpoints) - Add 503 service-not-ready tests for all 7 credits endpoints - Add batch processor tests for credits/extraartists processing (with artist ID, without artist ID, and invalid credit data) - Add credits endpoints to perftest config and runner (person credits, timeline, profile, connections, autocomplete, role leaderboard, and shared credits between person pairs) - Update documentation: API, graphinator, common, and explore READMEs now document Credits & Provenance feature, Person nodes, CREDITED_ON/SAME_AS relationships, and all 8 API endpoints https://claude.ai/code/session_01NomEjsUFJNWeFJpZaifDNU
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add 108 Vitest tests for credits.js (CreditsPanel class) - Add 2 batch_processor tests that execute batch_write closure for credits code paths (CREDITED_ON + SAME_AS queries) - Add data_normalizer test for non-dict extraartist entries (else branch) - Add app.test.js tests for genres and credits pane switching Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SimplicityGuy
force-pushed
the
claude/issue-164-kgcqp
branch
from
74e7e79 to
eb4331d
Compare
Cover d3 simulation tick handler, label text truncation, node click navigation, forceLink id accessor, and dy attribute callbacks in _renderConnections. Enhanced d3 mock to capture and invoke callbacks. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
E2E Coverage (webkit)
|
Contributor
E2E Coverage (firefox)
|
Contributor
E2E Coverage (chromium)
|
Contributor
E2E Coverage (webkit - iPhone 15)
|
Contributor
E2E Coverage (webkit - iPad Pro 11)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #164 — Surfaces the people behind the music (producers, engineers, mastering engineers, session musicians, designers) as first-class graph entities with queryable API endpoints and an interactive Explore UI pane.
Personnodes withCREDITED_ON(role, category) andSAME_AS(→Artist) relationshipsextraartistsfrom Discogs release XML, normalizes credits with role taxonomy, creates graph entities in both per-message and batch processing pathsTest plan
tests/common/test_credit_roles.py)tests/common/test_data_normalizer.py)tests/api/test_credits.py)tests/api/test_credits_queries.py)tests/graphinator/test_graphinator.py)tests/schema-init/test_neo4j_schema.py)https://claude.ai/code/session_01NomEjsUFJNWeFJpZaifDNU