Add union collections and live query unions#1150
Open
matthewdavi wants to merge 2 commits intoTanStack:mainfrom
Open
Add union collections and live query unions#1150matthewdavi wants to merge 2 commits intoTanStack:mainfrom
matthewdavi wants to merge 2 commits intoTanStack:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a Discord discussion with @KyleAMathews, this PR attempts to implement a union operator to join multiple live query collections in a single useLiveQuery call, which is needed for a number of things, among them, working around react hooks not being callable inside a loop.
🎯 Changes
This adds
unionandunionFromLiveQueryutilities for combining collections, with fail-fast key conflict detection and ref-counted dynamic unions driven by live query results. It also adds tests for union behavior, conflicts, and ref-counted removal.Issue: #58
Usage:
Local checks:
pnpm tsc -p packages/db/tsconfig.json --noEmitpnpm --filter "./packages/**" lint(warnings pre-existing in repo)pnpm --filter @tanstack/db-ivm buildpnpm --filter @tanstack/db buildpnpm --filter @tanstack/electric-db-collection buildpnpm --filter "./packages/**" test✅ Checklist
pnpm test:pr.🚀 Release Impact