You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unreachable willFetch branch in useQueries suspense promise collection.
In v4, useQueries allowed individual queries to set suspense: true/false, so a mix of suspense and non-suspense queries was possible. The willFetch branch handled prefetching for non-suspense queries within a suspense batch.
In v5, suspense was omitted from UseQueryOptions and useSuspenseQueries applies suspense: true to all queries uniformly. This makes the mixed suspense/non-suspense scenario unreachable through the public API, leaving the willFetch branch as dead code.
This PR removes:
The willFetch branch (else if (willFetch(result, isRestoring)))
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Removed the willFetch import and simplified the suspense preparation logic in useQueries by collapsing a nested conditional into a single combined condition, eliminating the secondary invocation path.
Removed willFetch import and refactored the conditional logic from a nested if-else structure to a combined condition (if (opts && shouldSuspend(opts, result))), eliminating the secondary path that previously triggered fetchOptimistic through willFetch.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested reviewers
TkDodo
manudeli
Poem
🐰 A hook grows sleek when branches fall,
Two paths collapse to one—that's all!
The willFetch fades like morning dew,
While shouldSuspend brings clarity through.
Simpler logic, cleaner way,
A rabbit cheers the code today! 🌟
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title clearly and specifically describes the main change: removing an unreachable 'willFetch' branch from suspense promise collection in useQueries.
Description check
✅ Passed
The PR description comprehensively covers all required sections: detailed explanation of changes, clear motivation/context, completed checklist items, and proper release impact assessment.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Comment @coderabbitai help to get the list of available commands and usage tips.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Remove the unreachable
willFetchbranch inuseQueriessuspense promise collection.In v4,
useQueriesallowed individual queries to setsuspense: true/false, so a mix of suspense and non-suspense queries was possible. ThewillFetchbranch handled prefetching for non-suspense queries within a suspense batch.In v5,
suspensewas omitted fromUseQueryOptionsanduseSuspenseQueriesappliessuspense: trueto all queries uniformly. This makes the mixed suspense/non-suspense scenario unreachable through the public API, leaving thewillFetchbranch as dead code.This PR removes:
willFetchbranch (else if (willFetch(result, isRestoring)))willFetchimport from./suspense✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.