Fix the bug of incorrect as_resizableRoundedImageWithCornerRadius background color.#1964
Open
yingchenw wants to merge 1 commit intoTextureGroup:masterfrom
Open
Fix the bug of incorrect as_resizableRoundedImageWithCornerRadius background color.#1964yingchenw wants to merge 1 commit intoTextureGroup:masterfrom
yingchenw wants to merge 1 commit intoTextureGroup:masterfrom
Conversation
The background of ELMContainerNode is created using a stretchable image, whose center 1x1 area will be later stretched to fit the entire content area. However, the color of the center area may be affected by its nearby pixels. This can cause the ELMContainerNode background area to have an incorrect background color. This fix repaints the center 1x1 area with the fillColor specified by the user. Fix some scuba tests. PRESUBMIT=passed BUG=179428110 FIXED=179428110 R=ganjam,konnork,rdarquea,siyusong,wiseoldduck,xpingzhou CC=jaceks,jayklub,yt-backstage+cl,yt-elements-eng+cl,yt-innertube-auto+changes,yt-ios-auto+cl,yt-ios-mainapp+cl,yt-reviewlog APPROVED=ganjam,konnork,siyusong,wiseoldduck,xpingzhou REQUIRED_REVIEW=1 DELTA_INCOMPLETE=9 (9 added, 0 deleted, 0 changed) DELTA_BY_EXTENSION=mm=9 OCL=356320759 FIG_CHANGESET=48007cddc301578950ddb29df65e18635e753b51 FIG_WORKSPACE=yingchenw/1362: P4 change: 358302665
|
|
mestir
approved these changes
Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The background in as_resizableRoundedImageWithCornerRadius is created using a stretchable image, whose center 1x1 area will be later stretched to fit the entire content area. However, the color of the center area may be affected by its nearby pixels. This can cause the image background area to have an incorrect background color.
This fix repaints the center 1x1 area with the fillColor specified by the user.