Hook timeseries chronix conversion by RiteshKarki27 · Pull Request #991 · VILLASframework/node

RiteshKarki27 · 2026-01-15T23:16:30Z

Summary:

This PR introduces a new create_chronics hook that processes CSV files containing load and generator power data and converts them into chronics files suitable for power grid simulation tools. The hook reads normalized active and reactive power values from Load and SGen CSV files, maps them to buses using a grid configuration file, and outputs formatted CSV files (optionally compressed with bzip2).

Features:

Ability to discover and process multiple Load and SGen CSV files.
Modification to node type file to allow multiple files to be read and stored in the buffer.
Mapping elements to buses using a grid configuration JSON file.

Changes:

New files:

lib/hooks/create_chronics.cpp: Main hook implementation.
include/villas/hooks/create_chronics.cpp: Hook header.
etc/examples/hooks/create_chronics.conf: Example configuration file.
tests/integration/hook-create_chronics.sh: Integration test for hook (current work-in-progress).

Modified files:

lib/nodes/file.cpp: Modify file implementation to read and store multiple files.
include/villas/nodes/file.hpp: Modified file header.

@al3xa23

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…hronics, fix issue raised during cppcheck Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…n check fail on CI Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…ohmann/json pkg Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…nics hook Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…mation. Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…missing dependencies Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

stv0g · 2026-01-26T08:35:54Z

@JitpanuM Please let me know, once this is ready for review.

A couple of questions ahead:

Is this Chronics format somewhere documented / standardized? I could not find any information about it. We need to add some references / URLs to the code to find more details about it.
Why does this need to be implemented in a hook? Wouldn't be a custom format (see lib/formats) be more appropriate?
Have you used a LLM to create this PR? If so, please clearly state the fact by adding a Co-Authored-by header in the commit decription.

Thanks :)

RiteshKarki27 · 2026-01-27T12:06:34Z

Thank you for your comment. I can answer the second and the third question.

The main reason this can be a hook is because it depends on node-type file to read multiple files and transform them into individual CSVs. Implementing it as a custom format would make more complicated to read and aggregate multiple CSV files and map them based on grid topology (here, a grid.json file).
I mainly used ChatGPT to get a template for the pull request description and added the individual files names manually. :)

al3xa23 · 2026-01-28T07:23:49Z

Regarding the first question: standardized is maybe too much to say, but grid2op is using chronics which we then later parse to opendss.
Hope this answers your questions :)

…entation in create_chronics.cpp Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

…eate-chronics hook Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>

al3xa23 · 2026-03-19T11:03:13Z

Hi @stv0g , this PR would also be ready. Let me know what you thhink. Thanks :)

stv0g · 2026-03-19T11:28:22Z

Thanks @al3xa23 for the update,

I would like to get some more feedback from other users on the design decisions behind this hook.
Its a bit unorthodox way to use the hook mechanism in VILLASnode.

@pjungkamp @windrad6 Do you have any opinions on this?

stv0g · 2026-03-19T11:28:53Z

@copilot Does this change fit the architecture of VILLASnode?

Copilot · 2026-03-19T11:29:01Z

@stv0g I've opened a new pull request, #1007, to work on those changes. Once the pull request is ready, I'll request review from you.

stv0g

I did some more review. But I am not very convinced this is the correct approach for the implementation.

Waiting for more feedback here :)

tests/integration/hook-create_chronics.sh

stv0g · 2026-03-19T11:33:52Z

python/villas/node/villas_pb2.py

Why was this file changed? It seems unrelated to the hook

stv0g · 2026-03-19T11:34:29Z

packaging/deps.sh

 fi

+# Build and install nlohmann/josn required for hook create_chronics
+if ! find ${PREFIX}/{include,share} -name "*nlohmann*" 2>/dev/null | grep -q . && \


Please use pkg-config to check for availability of dependencies.

stv0g · 2026-03-19T11:35:11Z

packaging/deps.sh

+fi
+
+# Build and install Bzip2 required for hook create_chronics
+if ! { [ -f /usr/local/include/bzlib.h ] && ldconfig -p  | grep -q libbz2; } && \


Same as above. Please use pkg-config. Take a look at the other dependencies. Most of them follow the same pattern.

stv0g · 2026-03-19T11:36:50Z

packaging/docker/Dockerfile.fedora-minimal

Please also update all the other Dockerfiles by adding the new dependencies.

stv0g · 2026-03-19T11:37:13Z

lib/hooks/create_chronics.cpp

+#include <villas/hooks/create_chronics.hpp>
+#include <villas/sample.hpp>
+
+#include "villas/node_compat.hpp"


Use angle brackets for VILLAS includes. See above.

Co-authored-by: Steffen Vogel <steffen.vogel@opal-rt.com> Signed-off-by: Ritesh Subhas Karki <riteshkarki@tutamail.com>

RiteshKarki27 added 13 commits December 14, 2025 22:22

add feature to read multiple files at once

fe3857a

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

add implementation for new hook create chronics

255f605

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix issue with faulty bzip2 check in deps.sh

4cda1c4

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix issue with faulty bzip2 check in deps.sh

a07f059

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics) include integration test for hook create-c…

32cb936

…hronics, fix issue raised during cppcheck Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Fix filename mismatch to avoid integratio…

d0a9c1c

…n check fail on CI Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics: fix build issue with nix due to missing bzip2

9db5ec1

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics: fix build issue with nix due to missing nl…

a0143ab

…ohmann/json pkg Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Fix cpp file format for CI pre-commit tests

0e6bebe

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Add configuration example for create_chro…

e1e09bf

…nics hook Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Fix build issue with fedora-minimal

ec10447

Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Add missing copyright and licensing infor…

fa417e6

…mation. Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Fix build issue with fedora-minimal, add …

6180701

…missing dependencies Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

RiteshKarki27 and others added 4 commits March 15, 2026 16:39

fix (hook-create-chronics): Remove redundant code from earlier implem…

2ebb53e

…entation in create_chronics.cpp Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

fix (hook-create-chronics): Improve example configuration file for cr…

262d288

…eate-chronics hook Signed-off-by: Ritesh.K <riteshkarki6@gmail.com>

Merge branch 'master' into hook-timeseries-chronix-conversion

6760680

fix(hook-timeseries-chronix-conversion): build pipeline

1569448

Signed-off-by: Alexandra <alexandra.bach@eonerc.rwth-aachen.de>

al3xa23 marked this pull request as ready for review March 19, 2026 11:02

al3xa23 requested review from n-eiling and stv0g as code owners March 19, 2026 11:02

Copilot AI mentioned this pull request Mar 19, 2026

Architectural review: create_chronics hook vs VILLASnode design patterns #1007

Draft

stv0g reviewed Mar 19, 2026

View reviewed changes

Update tests/integration/hook-create_chronics.sh

e256839

Co-authored-by: Steffen Vogel <steffen.vogel@opal-rt.com> Signed-off-by: Ritesh Subhas Karki <riteshkarki@tutamail.com>

Conversation

RiteshKarki27 commented Jan 15, 2026

Summary:

Features:

Changes:

New files:

Modified files:

Uh oh!

stv0g commented Jan 26, 2026

Uh oh!

RiteshKarki27 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

al3xa23 commented Jan 28, 2026

Uh oh!

al3xa23 commented Mar 19, 2026

Uh oh!

stv0g commented Mar 19, 2026

Uh oh!

stv0g commented Mar 19, 2026

Uh oh!

Copilot AI commented Mar 19, 2026

Uh oh!

stv0g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stv0g Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stv0g Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stv0g Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stv0g Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stv0g Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RiteshKarki27 commented Jan 27, 2026 •

edited

Loading