introduce EXCLUDE_NAMESPACE env variable to exclude namespaces from being watched#1837
Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Open
introduce EXCLUDE_NAMESPACE env variable to exclude namespaces from being watched#1837AndrewChubatiuk wants to merge 1 commit intomasterfrom
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 17 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:31">
P2: The changelog entry incorrectly states EXCLUDE_NAMESPACE accepts a list of environment variables; it should describe a list of namespaces. This misdocuments the feature and can confuse users configuring it.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/CHANGELOG.md">
<violation number="1" location="docs/CHANGELOG.md:31">
P1: Custom agent: **Changelog Review Agent**
Changelog entry does not follow the required structure for user-centric explanation (before/after behavior and visible impact) as mandated by the Changelog Review Agent rule. Entries missing the required structure must be rejected.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
docs/CHANGELOG.md
Outdated
| * FEATURE: [vmprobe](https://docs.victoriametrics.com/operator/resources/vmprobe/): added `spec.targets.kubernetes` property, that allows to configure probe for `ingress`, `pod` and `service` roles. See [#1078](https://github.com/VictoriaMetrics/operator/issues/1078) and [#1716](https://github.com/VictoriaMetrics/operator/issues/1716). | ||
| * FEATURE: [vmscrapeconfig](https://docs.victoriametrics.com/operator/resources/vmscrapeconfig/): added nomad_sd_config support. See [#1809](https://github.com/VictoriaMetrics/operator/issues/1809). | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): support VPA for vmcluster, vtcluster, vlcluster and vmauth. See [#1795](https://github.com/VictoriaMetrics/operator/issues/1795). Thanks to the @dctrwatson for the pull request [#1803](https://github.com/VictoriaMetrics/operator/pull/1803). | ||
| * FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `EXCLUDE_NAMESPACE` environment variable that accepts comma-separated list of namespaces that are excluded by operator. See [#1289](https://github.com/VictoriaMetrics/operator/issues/1289) |
Contributor
There was a problem hiding this comment.
P1: Custom agent: Changelog Review Agent
Changelog entry does not follow the required structure for user-centric explanation (before/after behavior and visible impact) as mandated by the Changelog Review Agent rule. Entries missing the required structure must be rejected.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/CHANGELOG.md, line 31:
<comment>Changelog entry does not follow the required structure for user-centric explanation (before/after behavior and visible impact) as mandated by the Changelog Review Agent rule. Entries missing the required structure must be rejected.</comment>
<file context>
@@ -28,7 +28,7 @@ aliases:
* FEATURE: [vmscrapeconfig](https://docs.victoriametrics.com/operator/resources/vmscrapeconfig/): added nomad_sd_config support. See [#1809](https://github.com/VictoriaMetrics/operator/issues/1809).
* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): support VPA for vmcluster, vtcluster, vlcluster and vmauth. See [#1795](https://github.com/VictoriaMetrics/operator/issues/1795). Thanks to the @dctrwatson for the pull request [#1803](https://github.com/VictoriaMetrics/operator/pull/1803).
-* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `EXCLUDE_NAMESPACE` environment variable that accepts comma-separated list of environment variables that are excluded by operator. See [#1289](https://github.com/VictoriaMetrics/operator/issues/1289)
+* FEATURE: [vmoperator](https://docs.victoriametrics.com/operator/): introduce `EXCLUDE_NAMESPACE` environment variable that accepts comma-separated list of namespaces that are excluded by operator. See [#1289](https://github.com/VictoriaMetrics/operator/issues/1289)
* BUGFIX: [vmagent](https://docs.victoriametrics.com/operator/resources/vmagent/): previously the operator requested `nodes/proxy` RBAC permissions even though vmagent did not use them; now this permission is no longer required, reducing the default privilege footprint for users running vmagent. See [#1753](https://github.com/VictoriaMetrics/operator/issues/1753).
</file context>
21c214f to
9a62ddc
Compare
9a62ddc to
c7fcff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1289
Summary by cubic
Introduce EXCLUDE_NAMESPACE to let the operator ignore specific namespaces in cluster-wide mode. Enforced via the manager cache using DefaultFieldSelector; cannot be combined with WATCH_NAMESPACE.
New Features
Refactors
Written for commit c7fcff4. Summary will update on new commits.