Run gdb commands before connection #97 by Gaswigue · Pull Request #99 · WebFreak001/code-debug

Gaswigue · 2017-03-08T16:34:45Z

No description provided.

WebFreak001 · 2017-03-08T19:22:02Z

It would be cool if environment-directory and target-select could also be inside the autorunBeforeCmds array. In line 232 where you only have sendCommand right now you would need to add .replace(/\$escaped_cwd/g, escape(cwd)).replace(/\$cwd/g, cwd).replace(/target/g, target) after the command string. This would make it much more configurable and it is really easily done like that. Then you can add "environment-directory \"$escaped_cwd\"" and "target-select remote $target" to the autorunBeforeCmds array

Gaswigue · 2017-03-08T19:50:53Z

It cross my mind to do as you say.
But as i am not very good at typescript/JS, I though there was a much better way to do so i didnt do it.
Thanks to your help. I'll check on that.

WebFreak001 · 2017-03-08T19:52:52Z

If you need any more help or suggestions, just push the code and I can use the github review feature. I think it's important to add this to SSH too, but you don't need to do that, that can be done in a separate PR or commit by me if you don't want to do it

Gaswigue · 2017-03-08T20:07:01Z

Ssh is not needed for me but I will code the improvement for this use case also. I have some other ideas ;)

V2

Gaswigue · 2017-03-09T12:30:31Z

src/gdb.ts

-		this.miDebugger = new MI2(args.gdbpath || "gdb", ["-q", "--interpreter=mi2"], args.debugger_args);
-		this.initDebugger();
+
+	private initiliaseDefaultValueArgs(args: CommonRequestArguments, attach: boolean) {


private initiliaseDefaultValueArgs(args: CommonRequestArguments, attach: boolean) {
New function to initialize unseted variable.
This avoid the launchRequest/attachRequest copy/past

The other parts of the program spell it initialize instead of initialise, can you keep it consistent and change it to the american spelling?

Gaswigue · 2017-03-09T12:33:02Z

src/gdb.ts

+			s => {return escape(s);
+		});
+
+		args.autorunBefore = args.autorunBefore.map(


args.autorun = args.autorun.map(s => {return escape(s);});
Resolve \ escape in $(workspaceroot) if we use it to load binary from gdb (command load)

don't use escape for this, it will put a \ before all other \ and " characters, this will manipulate user input and it will break all commands using " or \. I'm not quite sure what you mean with the workspaceroot.

I have a set of commands to send to gdb after connection
"load ${workspaceRoot}\\bin\\binary.x"
if i don't escape the path is wrong it remove all the \
the final command is
"load c:somedirAsomedirB\bin\binary.x" and not c:\somedirA\somedirB\bin\binary.x

I try to do
load ".\bin\binary.x" and it work. no need to use workspaceRoot. I can delete if needed this part.

WebFreak001

Looks like a good start, there were different commands depending if they were launch or attach, I need to check what this changes later, the PR shouldn't break any existing debugging configurations (so exactly the same commands should be sent if users don't provide custom commands). For example in lldb it is like that

WebFreak001 · 2017-03-09T12:53:22Z

package.json

+								"description": "mago commands to be run before connection",
+								"default": [
+									"gdb-set target-async on",
+									"environment-directory \"$cwd\"",


Just having $cwd without the quotes and instead adding the quotes in the replace function would be a better idea I think because it makes the default more clean and it's more obvious to the user because there are no random quotes around it.

WebFreak001 · 2017-03-09T12:55:18Z

src/backend/mi2/mi2.ts

 				args = args.concat([executable], this.preargs);
 			else
-				args = this.preargs;
+				args = this.preargs;	


there is a leading whitespace here

WebFreak001 · 2017-03-09T12:58:23Z

src/mago.ts

-	protected launchRequest(response: DebugProtocol.LaunchResponse, args: LaunchRequestArguments): void {
-		this.miDebugger = new MI2_Mago(args.magomipath || "mago-mi", ["-q"], args.debugger_args);
-		this.initDebugger();
+private initiliaseDefaultValueArgs(args: CommonRequestArguments, attach: boolean) {


Format your changed files with the vscode typescript formatter (alt-shift-f or ctrl-shift-i depending on your platform) please

WebFreak001 · 2017-03-09T13:00:55Z

src/backend/mi2/mi2lldb.ts

+			autorunBeforeCmds.forEach(command => {
+				cmds.push(this.sendCommand(command));
+			});
+			cmds.push(this.sendCommand("file-exec-and-symbols \"" + escape(executable) + "\""));


This is already in the autorunBeforeCmds

GitMensch · 2020-07-15T06:38:30Z

What is the state of this PR? Is it a draft? Is it abandoned?

GitMensch · 2022-03-04T22:31:49Z

It's been a while...
I'd like to take that up on current master (ideally after #323 and #316 were merged as those change the initialization):

adding the initializeToDefault() - and/or possibly possible use of resolving debug configuration #327 instead
add the new setting (I'd prefer "beforeConnect" instead of autorunBefore though)
"update" the async setting, see target-async, an alias for mi-async, is deprecated #297

Opinions?

Run gdb commands before connection WebFreak001#97

f44647b

Gabriel Cornesse added 2 commits March 9, 2017 13:17

Run gdb commands before connection WebFreak001#97

5ceae71

V2

Merge branch 'master' of https://github.com/Gaswigue/code-debug

2d3f07e

Gaswigue commented Mar 9, 2017

View reviewed changes

Fix forgotten modification

6ee9a19

WebFreak001 requested changes Mar 9, 2017

View reviewed changes

GitMensch mentioned this pull request Mar 4, 2022

target-async, an alias for mi-async, is deprecated #297

Open

Conversation

Gaswigue commented Mar 8, 2017

Uh oh!

WebFreak001 commented Mar 8, 2017

Uh oh!

Gaswigue commented Mar 8, 2017

Uh oh!

WebFreak001 commented Mar 8, 2017

Uh oh!

Gaswigue commented Mar 8, 2017

Uh oh!

Gaswigue Mar 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Gaswigue Mar 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WebFreak001 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GitMensch commented Jul 15, 2020

Uh oh!

GitMensch commented Mar 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gaswigue Mar 9, 2017 •

edited

Loading

Gaswigue Mar 9, 2017 •

edited

Loading

GitMensch commented Mar 4, 2022 •

edited

Loading