[Python] Challenge 6 (Unreviewed)#376
Open
randdane wants to merge 17 commits intoYearOfProgramming:masterfrom
Open
[Python] Challenge 6 (Unreviewed)#376randdane wants to merge 17 commits intoYearOfProgramming:masterfrom
randdane wants to merge 17 commits intoYearOfProgramming:masterfrom
Conversation
Contributor
|
Looks good for the most part. There is an edge case where a single number is not a range. so 11->11 would be an invalid output. but other than that your code is looking good. I had to implement the end of loop thing also. Another way you could do it is append a 0 to end of the list of numbers so you know it will fail and run your append condition at the end of a list. To make life easier as you go further you might look into unit tests. These make it easy to run identical tests when you change your code accounting for edge cases and the like.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I feel rather good about figuring this one out, but the last append outside of my for loop just doesn't feel right. I would appreciate any feedback.