Block on connect until handshake is done, Python 3 syntax, local imports#13
Open
abscond784 wants to merge 4 commits intoabeisgoat:masterfrom
Open
Block on connect until handshake is done, Python 3 syntax, local imports#13abscond784 wants to merge 4 commits intoabeisgoat:masterfrom
abscond784 wants to merge 4 commits intoabeisgoat:masterfrom
Conversation
Minor syntactical changes for Python 3 compatibility (prints need parenthesis).
…tion blocks until the handshake is done. Prior to this change, Firebase refs could be created and sent over the handshake connection instead of the actual connection. This caused several problems, including abeisgoat#3 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem that Firebase ref creation and send could happen during the handshake phase, which was causing some problems. It's addressed by blocking until the handshake phase is done.
Also, some minor syntax changes for Python 3, and local import fixes.