Fix detection of copyright statements without year in copyright declarations#4757
Open
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Open
Fix detection of copyright statements without year in copyright declarations#4757dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
c7ee2eb to
41656e7
Compare
Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
41656e7 to
f3fad13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4722
Description
This PR fixes detection of copyright statements that do not include a year in the declaration.
Previously, ScanCode required a year to be present alongside the copyright keyword. As a result, valid copyright statements such as:
Copyright The OpenTelemetry Authors(c) The OpenTelemetry Authorswere not detected.
This update adjusts the copyright detection grammar to allow copyright declarations without a year component, while preserving existing behavior for statements that include years.
After this change, such statements are correctly identified and extracted.
How to Reproduce (Before Fix)
Example file:
// Copyright The OpenTelemetry AuthorsRun:
Previously returned:
"copyrights": []After This Fix
The same scan now correctly detects:
{ "copyright": "Copyright The OpenTelemetry Authors" }Notes
Checklist