Enhance Apache Tomcat importer to collect commit information#2166
Closed
Tarun-goswamii wants to merge 1 commit intoaboutcode-org:mainfrom
Closed
Enhance Apache Tomcat importer to collect commit information#2166Tarun-goswamii wants to merge 1 commit intoaboutcode-org:mainfrom
Tarun-goswamii wants to merge 1 commit intoaboutcode-org:mainfrom
Conversation
- Add extract_commit_urls_from_advisory_group() function to scan entire advisory text - Support GitHub, SVN, and GitBox commit URLs - Improve commit capture rate by scanning all paragraphs instead of specific text patterns - Maintain 100% backward compatibility with existing functionality Fixes aboutcode-org#2129 Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: tarun111111 <tarunpuri2544@gmail.com>
Tarun-goswamii
force-pushed
the
enhancement/apache-tomcat-commits-2129
branch
from
5c04433 to
8781f30
Compare
Author
|
Hi @ziadhany, Thank you for reviewing my PR and for adding the "vibe-code" label. I would like to understand what specific aspects of my contribution fall under this label. Could you please let me know if there are any particular changes, improvements, or project-specific standards I should follow? I want to make sure my contribution aligns with the expected guidelines. I’m happy to update the PR based on your feedback. Thank you for your time and guidance. Best regards, |
Collaborator
|
@Tarun-goswamii, this PR is AI-generated using Claude and does not implement the logic correctly. Please don't submitt AI-generated code, as we have a strict policy against it. Please review this issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #2129
Summary
Enhanced the Apache Tomcat security advisory importer to collect commit information from advisories by scanning the entire advisory text instead of only specific paragraphs.
Changes
extract_commit_urls_from_advisory_group()function to extract commit URLsgenerate_advisory_data_objects()to use the new extraction functionTesting
Impact
github.com/apache/tomcat/commit/)svn.apache.orgwithrev=parameter)gitbox.apache.org)