Skip to content

Remove unnecessary pass statement in Gemini retry exception handler#8

Merged
achimrabus merged 2 commits intogemini-3-adjustmentsfrom
copilot/sub-pr-2-please-work
Dec 3, 2025
Merged

Remove unnecessary pass statement in Gemini retry exception handler#8
achimrabus merged 2 commits intogemini-3-adjustmentsfrom
copilot/sub-pr-2-please-work

Conversation

Copy link

Copilot AI commented Dec 3, 2025

Addresses code review feedback from PR #2 to remove redundant pass statement in inference_commercial_api.py.

Changes

  • Removed unnecessary pass statement at line 722 in exception handler
  • Retained explanatory comment that clarifies control flow

The pass statement added no functional value since the comment already documents the fall-through behavior:

except Exception as text_e:
    if verbose_block_logging:
        print(f"   Warning: Had parts but couldn't extract text: {text_e}")
    # Fall through to error handling below

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: achimrabus <67736443+achimrabus@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Gemini 3 API and preprocessing functionalities Remove unnecessary pass statement in Gemini retry exception handler Dec 3, 2025
Copilot AI requested a review from achimrabus December 3, 2025 07:54
@achimrabus achimrabus marked this pull request as ready for review December 3, 2025 09:42
@achimrabus achimrabus merged commit 782c2d7 into gemini-3-adjustments Dec 3, 2025
@achimrabus achimrabus deleted the copilot/sub-pr-2-please-work branch January 23, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants