Enhancement of feature matching processing distribution amongs available chunks#1928
Draft
servantftransperfect wants to merge 1 commit intodevelopfrom
Draft
Enhancement of feature matching processing distribution amongs available chunks#1928servantftransperfect wants to merge 1 commit intodevelopfrom
servantftransperfect wants to merge 1 commit intodevelopfrom
Conversation
aab762a to
311b8c6
Compare
311b8c6 to
da38f61
Compare
da38f61 to
0aec769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup loading and saving of pairs of indices (Output of ImageMatching)
Removed the "stream" version as they were never used
Cleanup exhaustive generation of pairs of indices (used if no imageMatching output)
Removed the obligation that pair.first < pair.second in the loaded file. This enable to have both directions in the same file (which is required for "star" roma)
Removed error if a pair contains twice the same value (To enable mirror matching)
Distribution of pairs to compute among chunks is now way more efficient ! Previous solution was to use the reference views as the items to distribute; But this is obviously creating problems as the numbers of pairs with the same reference image is not uniform at all.