feat: usage with gorhom bottom sheet#102
Closed
Benelini wants to merge 1 commit intoanday013:mainfrom
Closed
Conversation
Owner
|
@Benelini Hi, firstly thank you for your efforts. What about the people who're not using this lib with any bottom sheet? Is it right to bind everyone to have an extra dependency? |
Contributor
|
This is wrong. The package shouldn't depend on gorhom nor on RNGH |
Owner
|
What you can do is to expose a prop for custom input rendering. Ex: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added functionality so that this package can be used with gorhom/react-native-bottom-sheet. This mostly solves keyboard behaviour when the otp entry is used in the bottom sheet, otherwise its very tricky.
I also updated the types accordingly since RN 79 requires React 19 types.