For connections created outside the global field, use try-with-resour… by jeanouii · Pull Request #1667 · apache/activemq

jeanouii · 2026-02-11T20:31:54Z

…ces to avoid leaks

Copilot

Pull request overview

Updates AMQP transport test code to ensure JMS Connection instances are reliably closed (especially on exceptions) by using try-with-resources, reducing the chance of resource leaks during test runs.

Changes:

Wrap JMS Connection usage in try-with-resources blocks across multiple AMQP-related test classes.
Remove manual close() / finally patterns made redundant by try-with-resources (including a double-close case).
Adjust test structure (indentation / block scoping) to keep assertions within the resource lifecycle.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 14 comments.

File	Description
`activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSLargeMessageSendRecvTest.java`	Wraps per-test connection creation in try-with-resources to ensure closure.
`activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSInteroperabilityTest.java`	Wraps OpenWire/AMQP connections in try-with-resources across multiple interop tests.
`activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java`	Wraps AMQP and OpenWire JMS connections in try-with-resources; removes redundant close logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSLargeMessageSendRecvTest.java

Copilot · 2026-02-12T14:37:36Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java

+            Message message = c.receive(1000);

-        assertTrue(message instanceof BytesMessage);
-        Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");
-        assertTrue("Didn't use the correct transformation, expected NATIVE", nativeTransformationUsed);
-        assertEquals(DeliveryMode.PERSISTENT, message.getJMSDeliveryMode());
-        assertEquals(7, message.getJMSPriority());
+            assertTrue(message instanceof BytesMessage);
+            Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");
+            assertTrue("Didn't use the correct transformation, expected NATIVE", nativeTransformationUsed);
+            assertEquals(DeliveryMode.PERSISTENT, message.getJMSDeliveryMode());
+            assertEquals(7, message.getJMSPriority());


c.receive(1000) can return null; assertTrue(message instanceof BytesMessage) will then fail with a generic message. Add an assertNotNull (with a helpful message) before the type assertion to make failures easier to diagnose.

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSInteroperabilityTest.java

Copilot · 2026-02-12T14:37:37Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSInteroperabilityTest.java

+                        LOG.debug("Appclication Property not set by client: {}", propertyName);
+                        fail("Appclication Property not set by client: " + propertyName);


Typo in log / failure message: "Appclication" should be "Application" (both the LOG message and fail(...) message).

Copilot · 2026-02-12T14:37:39Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSInteroperabilityTest.java

+                        LOG.debug("Appclication Property set by client is: {}", propertyName);
+                        if (!inbound.propertyExists(propertyName)) {


Typo in log message: "Appclication" should be "Application".

Copilot · 2026-02-12T14:37:39Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/JMSInteroperabilityTest.java

+                        LOG.debug("Appclication Property not set by client: {}", propertyName);
+                        fail("Appclication Property not set by client: " + propertyName);


Typo in log / failure message: "Appclication" should be "Application" (both the LOG message and fail(...) message).

Copilot · 2026-02-12T14:37:39Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java

-        assertEquals(DeliveryMode.PERSISTENT, message.getJMSDeliveryMode());
-        assertEquals(7, message.getJMSPriority());
+            assertTrue(message instanceof BytesMessage);
+            Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");


The variable 'nativeTransformationUsed' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.

Suggested change

Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

Copilot · 2026-02-12T14:37:40Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java

+            assertNotNull("Should have received a message", message);
+            LOG.info("Recieved message: {}", message);
+            assertTrue(message instanceof BytesMessage);
+            Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");


The variable 'nativeTransformationUsed' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.

Suggested change

Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

Copilot · 2026-02-12T14:37:40Z

activemq-amqp/src/test/java/org/apache/activemq/transport/amqp/AmqpTransformerTest.java

-        assertFalse("Didn't use the correct transformation, expected NOT to be NATIVE", nativeTransformationUsed);
-        assertEquals(DeliveryMode.PERSISTENT, message.getJMSDeliveryMode());
+            assertTrue(message instanceof TextMessage);
+            Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");


The variable 'nativeTransformationUsed' is only assigned values of primitive type and is never 'null', but it is declared with the boxed type 'Boolean'.

Suggested change

Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

…/JMSLargeMessageSendRecvTest.java Co-authored-by: Copilot <[email protected]>

…/AmqpTransformerTest.java Co-authored-by: Copilot <[email protected]>

…/JMSInteroperabilityTest.java Co-authored-by: Copilot <[email protected]>

For connections created outside the global field, use try-with-resour…

57109cc

…ces to avoid leaks

jeanouii requested a review from Copilot February 12, 2026 14:31

Copilot started reviewing on behalf of jeanouii February 12, 2026 14:31 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

jeanouii and others added 3 commits February 12, 2026 15:38

Update activemq-amqp/src/test/java/org/apache/activemq/transport/amqp…

64d5aee

…/JMSLargeMessageSendRecvTest.java Co-authored-by: Copilot <[email protected]>

Update activemq-amqp/src/test/java/org/apache/activemq/transport/amqp…

cb3db14

…/AmqpTransformerTest.java Co-authored-by: Copilot <[email protected]>

Update activemq-amqp/src/test/java/org/apache/activemq/transport/amqp…

5ff570f

…/JMSInteroperabilityTest.java Co-authored-by: Copilot <[email protected]>

jeanouii merged commit 4809b1e into apache:main Feb 12, 2026
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For connections created outside the global field, use try-with-resour…#1667

For connections created outside the global field, use try-with-resour…#1667
jeanouii merged 4 commits intoapache:mainfrom
jeanouii:fix/amqp-leak-connections

jeanouii commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Copilot AI Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		LOG.debug("Appclication Property not set by client: {}", propertyName);
		fail("Appclication Property not set by client: " + propertyName);

		LOG.debug("Appclication Property set by client is: {}", propertyName);
		if (!inbound.propertyExists(propertyName)) {

	Boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");
	boolean nativeTransformationUsed = message.getBooleanProperty("JMS_AMQP_NATIVE");

Conversation

jeanouii commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant