Fix security, CI, and dependency issues in JDBC driver#2331
Closed
jrgemignani wants to merge 1 commit intoapache:masterfrom
Closed
Fix security, CI, and dependency issues in JDBC driver#2331jrgemignani wants to merge 1 commit intoapache:masterfrom
jrgemignani wants to merge 1 commit intoapache:masterfrom
Conversation
Note: This PR was created with AI tools and a human. Security audit of the JDBC driver source code (16 main + 5 test Java files). The driver is a pure type-mapping layer (PGobject/agtype serialization only) with no query-building APIs, so it has minimal attack surface. No application-level vulnerabilities were found. Update all dependencies to address critical vulnerabilities: - postgresql 42.6.0 -> 42.7.5: fixes CVE-2024-1597 (Critical, CVSS 10.0: SQL injection via line comment generation in simple query mode) - commons-text 1.10.0 -> 1.13.0: maintenance update (1.10.0 was not affected by CVE-2022-42889) - antlr4 4.12.0 -> 4.13.2: bug fixes, Java 17+ improvements - junit-jupiter 5.9.3 -> 5.11.4: maintenance update - testcontainers 1.18.0 -> 1.20.4: stability improvements - slf4j 2.0.7 -> 2.0.16: maintenance update - Gradle wrapper 7.0 -> 8.5: Java 17/21 build support Note: postgresql 42.7.7+ also fixes CVE-2025-49146 (High: auth bypass with channelBinding=require). Version 42.7.5 was chosen as a conservative update to fix the Critical CVE while minimizing risk from protocol changes in newer releases. Fix root cause of CI test flakiness in BaseDockerizedTest: - Add testcontainers wait strategy (Wait.forLogMessage) to ensure PostgreSQL is fully ready before attempting JDBC connection - Add sslmode=disable to JDBC URL, required because postgresql 42.7.x attempts SSL negotiation by default and the AGE Docker image does not have SSL configured - Remove silent exception swallowing (catch/println) on connection failure so test setup errors are reported immediately modified: drivers/jdbc/gradle/wrapper/gradle-wrapper.properties modified: drivers/jdbc/lib/build.gradle.kts modified: drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java
Contributor
Author
|
This will have to be reworked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR was created with AI tools and a human.
Security audit of the JDBC driver source code (16 main + 5 test Java files). The driver is a pure type-mapping layer (PGobject/agtype serialization only) with no query-building APIs, so it has minimal attack surface. No application-level vulnerabilities were found.
Update all dependencies to address critical vulnerabilities:
Note: postgresql 42.7.7+ also fixes CVE-2025-49146 (High: auth bypass with channelBinding=require). Version 42.7.5 was chosen as a conservative update to fix the Critical CVE while minimizing risk from protocol changes in newer releases.
Fix root cause of CI test flakiness in BaseDockerizedTest:
modified: drivers/jdbc/gradle/wrapper/gradle-wrapper.properties
modified: drivers/jdbc/lib/build.gradle.kts
modified: drivers/jdbc/lib/src/test/java/org/apache/age/jdbc/BaseDockerizedTest.java