GH-49078: [FS][Azure] Fix lossy pickling of SubTreeFileSystem(base_path, AzureFileSystem(...))#49140
Open
Tom-Newton wants to merge 16 commits intoapache:mainfrom
Open
Conversation
|
|
This reverts commit 7cee1d0.
28ad544 to
d0a02e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fix #49078
What changes are included in this PR?
AzureOptions, for the values that are currently stored only on the python side.ClearCredentials, so that it can't get into strange states by configuring one credential type then another. IMO configuring the credentials during initialisation on theAzureOptionswould be neater but I don't want to make this PR too big.AzureOptions::Equalsselfattributes and instead depend on getters from C++ side.Are these changes tested?
Equalsand newly added getter methods.pickle_with_and_without_subtree_filesystem, which can be used in place of thepickle_module. This adds test combinations with and without wrapping the filesystem in aSubTreeFilesystembefore pickling it.Are there any user-facing changes?
Only that pickling
SubTreeFileSystem(base_path, AzureFileSystem(...))now works properly.SubTreeFileSystem(base_path, AzureFileSystem(...))is lossy #49078