GH-44655: [C++][Python] Enable building AzureFileSystem in PyArrow wheels on Windows #49170
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
|
|
Contributor
Author
|
The one test failure is https://github.com/apache/arrow/actions/runs/21764368585/job/62795990526?pr=49170 which has already been timing out on main for a couple weeks. |
Member
|
@github-actions crossbow submit -g wheel |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
Member
|
@github-actions crossbow submit -g wheel |
|
Revision: 92ebfcc Submitted crossbow builds: ursacomputing/crossbow @ actions-285547f40f
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR is a follow up to #48971 and should address #44655. Previously, the C++ AzureFileSystem couldn't be compiled on Windows due to a incomplete type definition. Now that this has been resolved, we should be able to enable building on the Windows Platform for PyArrow as well.
What changes are included in this PR?
This PR sets the flags to enable building AzureFileSystem for PyArrow wheels on Windows. This will bring functionality in line with the Linux and macOS wheel builds.
Are these changes tested?
These changes enable existing testing that's used for other C++ Filesystems in PyArrow. Tests will validate the class is importable from the built wheels which seems to be the existing precedent. I can add other tests if needed, but will likely need some direction.
Are there any user-facing changes?
This PR will enable use of AzureFileSystem on Windows. Currently, trying to use or import the AzureFileSystem from PyArrow raises an ArrowNotImplementedError.
After these changes, support should be available.