[CELEBORN-2270] Fix problem with eviction to tiered storage during partition split#3610
Open
eolivelli wants to merge 18 commits intoapache:mainfrom
Open
[CELEBORN-2270] Fix problem with eviction to tiered storage during partition split#3610eolivelli wants to merge 18 commits intoapache:mainfrom
eolivelli wants to merge 18 commits intoapache:mainfrom
Conversation
This commit adds only tests and some useful debug information about using MEMORY and S3 storage.
eolivelli
force-pushed
the
CELEBORN-2270-fix-partition-split
branch
from
756d25e to
7d621c1
Compare
eolivelli
force-pushed
the
CELEBORN-2270-fix-partition-split
branch
from
7d621c1 to
a9e2063
Compare
eolivelli
force-pushed
the
CELEBORN-2270-fix-partition-split
branch
from
d89700e to
140549a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is stacked on top of #3608
Please consider only 756d25e
What changes were proposed in this pull request?
Handle the eviction to a different location type.
Why are the changes needed?
Because it may happen that a MEMORY file is to be evicted to another storage type (i.e. S3). This does not work.
Usually, as described in tests in #3608 when you have tiered storage, the primary partition type is usually not MEMORY, but it may happen that during a partition split the client decides to use MEMORY.
This patch fixes the problem on the worker side.
An alternative fix would be to change the behavior of the client, and simulate what the master does when offering slots.
Such a change would be more involved and it won't make the server side resilient to this scenario.
Does this PR resolve a correctness bug?
No
Does this PR introduce any user-facing change?
No
How was this patch tested?