Skip to content

Conversation

@924060929
Copy link
Contributor

AggregateNode compute digest of query cache should consider sortByGroupKey

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 2, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.29% (1792/2260)
Line Coverage 64.76% (31834/49158)
Region Coverage 65.44% (15888/24280)
Branch Coverage 55.98% (8441/15078)

@doris-robot
Copy link

TPC-H: Total hot run time: 31826 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df49a4b6f43172bb360c0be63cdac2f9fa1ae05c, data reload: false

------ Round 1 ----------------------------------
q1	17638	5312	5026	5026
q2	2035	313	195	195
q3	10159	1353	717	717
q4	10210	861	319	319
q5	7496	2168	1867	1867
q6	204	183	151	151
q7	883	736	617	617
q8	9268	1335	1096	1096
q9	5296	4829	4863	4829
q10	6828	1957	1573	1573
q11	518	306	300	300
q12	357	376	217	217
q13	17791	4110	3226	3226
q14	230	252	221	221
q15	912	827	826	826
q16	702	664	626	626
q17	635	769	498	498
q18	6818	6403	6433	6403
q19	1332	1008	616	616
q20	385	342	231	231
q21	2562	2019	2001	2001
q22	363	322	271	271
Total cold run time: 102622 ms
Total hot run time: 31826 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5337	5299	5281	5281
q2	265	326	249	249
q3	2148	2695	2235	2235
q4	1352	1734	1308	1308
q5	4291	4129	4246	4129
q6	215	183	139	139
q7	2204	2147	1898	1898
q8	2636	2458	2483	2458
q9	7408	7567	7508	7508
q10	2901	3049	2554	2554
q11	546	493	477	477
q12	681	736	679	679
q13	3765	4438	3416	3416
q14	307	321	292	292
q15	902	821	822	821
q16	691	724	727	724
q17	1147	1267	1462	1267
q18	8165	7702	8048	7702
q19	914	863	882	863
q20	2186	2205	2079	2079
q21	4754	4341	4187	4187
q22	597	530	556	530
Total cold run time: 53412 ms
Total hot run time: 50796 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.49% (19327/36819)
Line Coverage 35.99% (179635/499089)
Region Coverage 32.38% (139360/430435)
Branch Coverage 33.34% (60283/180819)

@doris-robot
Copy link

ClickBench: Total hot run time: 27.76 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit df49a4b6f43172bb360c0be63cdac2f9fa1ae05c, data reload: false

query1	0.06	0.05	0.05
query2	0.14	0.08	0.06
query3	0.34	0.09	0.07
query4	1.61	0.10	0.10
query5	0.25	0.24	0.24
query6	1.14	0.66	0.65
query7	0.04	0.02	0.03
query8	0.07	0.06	0.06
query9	0.58	0.51	0.50
query10	0.55	0.55	0.55
query11	0.25	0.13	0.13
query12	0.26	0.14	0.14
query13	0.62	0.62	0.59
query14	0.98	1.01	0.97
query15	0.90	0.81	0.82
query16	0.39	0.43	0.38
query17	1.04	1.07	1.05
query18	0.23	0.22	0.23
query19	1.85	1.83	1.87
query20	0.02	0.01	0.01
query21	15.38	0.29	0.24
query22	4.96	0.09	0.09
query23	15.40	0.39	0.22
query24	2.27	0.49	0.32
query25	0.10	0.10	0.10
query26	0.19	0.17	0.18
query27	0.10	0.09	0.10
query28	3.49	1.12	0.96
query29	12.53	3.97	3.19
query30	0.31	0.12	0.11
query31	2.79	0.67	0.43
query32	3.24	0.61	0.49
query33	2.99	3.00	3.04
query34	16.03	5.08	4.51
query35	4.46	4.40	4.41
query36	0.61	0.50	0.48
query37	0.25	0.08	0.08
query38	0.20	0.06	0.06
query39	0.07	0.05	0.05
query40	0.19	0.17	0.16
query41	0.12	0.07	0.07
query42	0.08	0.05	0.05
query43	0.08	0.06	0.07
Total cold run time: 97.16 s
Total hot run time: 27.76 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.67% (25875/36103)
Line Coverage 54.29% (270330/497942)
Region Coverage 51.63% (224533/434853)
Branch Coverage 53.16% (96520/181556)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.67% (25875/36103)
Line Coverage 54.29% (270339/497942)
Region Coverage 51.63% (224519/434853)
Branch Coverage 53.17% (96533/181556)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants