[branch-4.0] pick some expr-related PRs into branch-4.0. #60436
+4,034
−392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…execute_conjuncts. (apache#58636) Previously, execute_conjuncts had to check on every operation whether it was an rf wrapper; now that check is encapsulated in a virtual method. This has the advantage that in the _always_true case it can return immediately without constructing a column. The variables related to the rf check have been moved into VExprContext, so we no longer need to worry about concurrency. set in be.conf ``` sys_log_verbose_modules = runtime_filter_selectivity ``` output ``` I20251204 18:02:22.102540 3778890 runtime_filter_selectivity.h:53] Runtime filter[1] selectivity update: filter_rows: 144839, input_rows: 145799, filter rate: 0.9945866141732284, ignore_thredhold: 0.059489920657150065, counter: 35 , always_true: false ```
…er. (apache#59835) This will reduce hashset lookups.
…pache#59830) ```mysql mysql> set enable_strict_cast = true; Query OK, 0 rows affected (0.00 sec) mysql> select count( -> if(number < 128 , -> cast(number as tinyint), -> cast(number as String)) -> ) from numbers("number" = "300"); ERROR 1105 (HY000): errCode = 2, detailMessage = (127.0.0.1)[INVALID_ARGUMENT]Value 128 out of range for type tinyint mysql> set short_circuit_evaluation = true; Query OK, 0 rows affected (0.00 sec) mysql> select count( -> if(number < 128 , -> cast(number as tinyint), -> cast(number as String)) -> ) from numbers("number" = "300"); +-----------------------------------------------------------------------------------------------------------------+ | count( if(number < 128 , cast(number as tinyint), cast(number as String)) ) | +-----------------------------------------------------------------------------------------------------------------+ | 300 | +-----------------------------------------------------------------------------------------------------------------+ ```
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#58636
#59835
#59830
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)