Feat: Enhance service method retrieval and invocation features by Similarityoung · Pull Request #1429 · apache/dubbo-admin

Similarityoung · 2026-03-08T09:44:20Z

Description

This PR adds structured service method introspection, provider instance discovery, and generic invoke capabilities to the Dubbo Admin console. It also tightens the generic invoke contract so that parameter types are resolved from provider metadata instead of being supplied by the client, and makes retry behavior safer for non-idempotent calls.

What changed

Added console APIs for service method and provider discovery:
- GET /api/v1/service/provider-instances
- GET /api/v1/service/methods
- GET /api/v1/service/method/detail
- POST /api/v1/service/generic/invoke

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

… request model

…ovider app name in ServiceMethodsReq

…ture retrieval

…t struct

Copilot

Pull request overview

This PR adds service method introspection endpoints and a metadata-driven generic invocation flow to the Dubbo Admin console, shifting generic invoke parameter type resolution from client input to provider metadata.

Changes:

Added console APIs for listing service methods, fetching method details (including signature/types closure), and performing generic invoke.
Implemented provider-metadata-based overload resolution via methodName + signature and refactored generic invoke argument decoding using []json.RawMessage.
Updated ZK node creation flag usage and bumped/adjusted Go module dependencies to support the new generic invoke implementation.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/governor/zk/governor.go	Adjusts ZK node creation flags for compatibility.
pkg/console/service/service_generic_invoke_decode.go	Adds typed argument decoding helpers for generic invoke based on resolved parameter types.
pkg/console/service/service_generic_invoke.go	Implements generic invoke flow: metadata lookup, overload resolution, target selection, and RPC invocation.
pkg/console/service/service.go	Adds provider-metadata-backed method discovery and method detail/type-closure building.
pkg/console/router/router.go	Registers new service routes for methods, method detail, and generic invoke under `/api/v1/service`.
pkg/console/model/service.go	Adds request/response models for method discovery, method detail, and generic invoke (including `signature` and raw args).
pkg/console/handler/service.go	Adds handlers wiring the new endpoints to service layer functions.
go.mod	Updates dubbo-go dependency and adds hessian2 + other indirects needed for new invoke path.
go.sum	Updates dependency checksums accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

pkg/console/service/service.go

Copilot · 2026-03-08T09:50:00Z

pkg/console/service/service_generic_invoke.go

+var invokeGenericServiceRPC = func(callCtx context.Context, invocation genericInvocation) (any, error) {
+	ins, err := dubbo.NewInstance(dubbo.WithName(genericInvokeInstanceName))
+	if err != nil {
+		return nil, err
+	}
+
+	cli, err := ins.NewClient(
+		client.WithClientProtocolTriple(),
+		client.WithClientSerialization(dubboconstant.Hessian2Serialization),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	svc, err := cli.NewGenericService(
+		invocation.ServiceName,
+		client.WithURL(invocation.URL),
+		client.WithVersion(invocation.Version),
+		client.WithGroup(invocation.Group),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return svc.Invoke(callCtx, invocation.MethodName, invocation.ParameterTypes, invocation.Args)
+}


invokeGenericServiceRPC creates a new Dubbo instance + client + generic service on every invocation. This is likely expensive and may also accumulate background resources (connections, goroutines) depending on the dubbo-go implementation. Consider initializing and reusing a singleton instance/client (and, if possible, a cached generic service per service/version/group) with proper lifecycle management instead of rebuilding everything per request.

Optimization can be made in the future

copilot这里说的有道理，这里可以在代码里记一个todo，加上client的缓存

pkg/console/service/service_generic_invoke.go

pkg/console/service/service_generic_invoke_decode.go

Similarityoung · 2026-03-08T09:57:46Z

Code review

Found 1 issue:

Generic invoke leaks raw upstream/internal RPC errors back to the client instead of following the console's usual stable InternalError pattern. The rest of pkg/console/service returns fixed user-facing messages and logs the cause server-side, but this new path returns err.Error() directly, which can expose transport/provider details and make API responses inconsistent.

dubbo-admin/pkg/console/service/service_generic_invoke.go

Lines 148 to 152 in c04698c

    
           if err != nil { 
        
           	logger.Errorf("generic invoke failed, service=%s, method=%s, providerApp=%s, target=%s:%d, cause: %v", 
        
           		req.ServiceName, req.MethodName, providerAppName, target.instance.Spec.Ip, target.port, err) 
        
           	return nil, bizerror.New(bizerror.InternalError, err.Error()) 
        
           }

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

…rameter count validation

…viceGeneric in ServiceGenericInvoke

robocanic

Great Work! I left some comments and hope you can discuss them with me.

pkg/console/model/service.go

pkg/console/service/service.go

pkg/console/service/service_generic_invoke.go

robocanic · 2026-03-08T13:35:18Z

pkg/console/service/service_generic_invoke.go

+var invokeGenericServiceRPC = func(callCtx context.Context, invocation genericInvocation) (any, error) {
+	ins, err := dubbo.NewInstance(dubbo.WithName(genericInvokeInstanceName))
+	if err != nil {
+		return nil, err
+	}
+
+	cli, err := ins.NewClient(
+		client.WithClientProtocolTriple(),
+		client.WithClientSerialization(dubboconstant.Hessian2Serialization),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	svc, err := cli.NewGenericService(
+		invocation.ServiceName,
+		client.WithURL(invocation.URL),
+		client.WithVersion(invocation.Version),
+		client.WithGroup(invocation.Group),
+	)
+	if err != nil {
+		return nil, err
+	}
+
+	return svc.Invoke(callCtx, invocation.MethodName, invocation.ParameterTypes, invocation.Args)
+}


copilot这里说的有道理，这里可以在代码里记一个todo，加上client的缓存

…enhance service provider metadata indexing

… request validation

…alidation

…ion support

…invocation

- 添加环境变量 `VITE_MOCK_ENABLED` 用于启用 mock 数据模式 - 更新 `package.json` 脚本以添加 `dev:mock` 用于 mock 数据开发环境 - 新增 `mockLogin.ts` 文件，提供 mock 登录和登出接口 - 修改 `request.ts`，根据环境变量切换请求的 `baseURL` - 优化 `main.ts`，根据 mock 模式自动导入 mock API 并更新认证状态

- 新增 axios 作为 HTTP 客户端依赖 - 优化 mock 数据接口，包括应用指标、流量权重、灰度配置等 - 更新 package.json 文件以添加 axios 依赖 - 修改多个 mock 接口以适应新的架构和数据结构

… into feature/generic

sonarqubecloud · 2026-03-25T15:54:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Similarityoung added 7 commits March 4, 2026 20:06

feat: add endpoint to retrieve service method names and corresponding…

6fc5dde

… request model

feat: add endpoint and logic to retrieve service method details

43725cd

feat: trim whitespace from service name, mesh, group, version, and pr…

1f14a6d

…ovider app name in ServiceMethodsReq

feat: enhance service method handling with overload support and signa…

4e19307

…ture retrieval

feat: add generic service invocation support

9c6ec77

feat: refactor triple RPC instance selection to use a dedicated targe…

59fc988

…t struct

feat: remove obsolete service methods test file

c04698c

Copilot AI review requested due to automatic review settings March 8, 2026 09:44

Copilot started reviewing on behalf of Similarityoung March 8, 2026 09:44 View session

Copilot AI reviewed Mar 8, 2026

View reviewed changes

Similarityoung added 2 commits March 8, 2026 19:31

feat: improve error handling in generic service invocation and add pa…

e6b7660

…rameter count validation

feat: remove unnecessary variable and directly call service.InvokeSer…

4d87df4

…viceGeneric in ServiceGenericInvoke

robocanic reviewed Mar 8, 2026

View reviewed changes

Similarityoung and others added 16 commits March 8, 2026 22:37

feat: improve query validation by using strutil for blank checks and …

a155f06

…enhance service provider metadata indexing

feat: add endpoint to retrieve service provider instances and enhance…

44764bb

… request validation

feat: update service provider instance handling and improve request v…

5db31ba

…alidation

feat: enhance generic service invocation with protocol and serializat…

a58a0e7

…ion support

feat: add normalization functions for JSON values in generic service …

6844a2c

…invocation

feat: add normalization functions for JSON values in generic service …

d8b8822

…invocation

feat: refine retry logic for service invocation failures

ef85cd3

Merge branch 'develop' into feature/generic

fb048d1

feat(api): 新增 mock 服务方法列表、详情及泛化调用接口

0c7f899

Merge branch 'generic-front' of github.com:Similarityoung/dubbo-admin…

3a4e24e

… into feature/generic

feat(api): add front func

4f38739

feat(ui-vue3): improve func empty description

a9ea154

feat(ui-vue3): code format

1bb1d88

feat(api): update mock interface

b80b4cd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Enhance service method retrieval and invocation features#1429

Feat: Enhance service method retrieval and invocation features#1429
Similarityoung wants to merge 25 commits intoapache:developfrom
Similarityoung:feature/generic

Similarityoung commented Mar 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 8, 2026

Uh oh!

Similarityoung Mar 8, 2026

Uh oh!

robocanic Mar 8, 2026

Uh oh!

Uh oh!

Uh oh!

Similarityoung commented Mar 8, 2026

Uh oh!

robocanic left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robocanic Mar 8, 2026

Uh oh!

sonarqubecloud bot commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Similarityoung commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What changed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Similarityoung Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

robocanic Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Similarityoung commented Mar 8, 2026

Code review

Uh oh!

robocanic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robocanic Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Mar 25, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Similarityoung commented Mar 8, 2026 •

edited

Loading