Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds TLS/SSL support to the Apache IoTDB C# client, allowing secure connections between clients and IoTDB servers using X.509 certificates.
Changes:
- Added SSL configuration options (
SetUseSslandSetCertificatePath) to both SessionPool and TableSessionPool builders - Updated SessionPool constructors and connection logic to support SSL/TLS transport using
TTlsSocketTransport - Cleaned up unused imports (System.Net.Sockets, System.Numerics, Microsoft.Extensions.Configuration)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/Apache.IoTDB/SessionPool.Builder.cs | Added SSL configuration fields and builder methods; updated constructor calls to pass SSL parameters |
| src/Apache.IoTDB/TableSessionPool.Builder.cs | Added SSL configuration fields and builder methods; updated SessionPool instantiation with SSL parameters |
| src/Apache.IoTDB/SessionPool.cs | Added SSL fields, updated constructors, and modified CreateAndOpen to conditionally use TLS transport based on SSL configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.