Merged
Conversation
Equivalent to Map Adapter Symmetry tests
Config adapter does not win in JsonbTypeAdapter test
Equivalent JsonbTypeAdapter test fails with java.lang.ClassCastException: Cannot cast sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl to java.lang.Class
Equivalent JsonbTypeAdapter test EmailClass adapter wins on write
Equivalent JsonbTypeAdapter test fails with ClassCastException
Equivalent JsonbTypeAdapter test EmailClass adapter wins
Contributor
Author
|
Discoveries:
Note all tests that fail have been marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some differences in behavior on reading vs writing with JsonbTypeAdapters. They appear to have very different code paths and some caching issues that can alter behavior if reads are done after writes.
These test attempt to verify:
First round of tests cover JsonbTypeAdapter, JsonbTypeDeserializer and JsonbTypeSerializer. Tests that fail are ignored so this can be a passing PR. Inconsistencies are documented.
Don't have time now, but would like to return to this at some point in the future to cover JsonbDateFormat, JsonbNumberFormat and the four flavors of JohnzonConverter. I would also like to test meta-annotation versions of the above.