Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off: this does not currently compile.
This PR is really for a discussion to talk more about #519. To that end, this PR does a few things as a discussion point:
log4cxx_time_tto bestd::chrono::time_pointinstead. This results in better code semantics at the risk of making the code more annoying to deal with(chrono is not a very fun API)Fileimplementation with classes fromstd::filesystemorstd::fstreamas appropriateIf we want to do some/all of these, I would create some new PRs to do these in smaller batches, as this has become very time consuming to try and do since these are rather invasive changes.