[networks]: add decoder/encoder to Attachment and NetworkStatus#1216
Merged
JaewonHur merged 6 commits intoapple:mainfrom Mar 17, 2026
Merged
Conversation
saehejkang
force-pushed
the
add-init-decoder-for-attachment-and-network-config
branch
from
96a7b48 to
16eb09b
Compare
JaewonHur
approved these changes
Feb 18, 2026
Contributor
Author
|
@jglogan bringing this to your inbox as it a blocker for socktainer and should get merged soon |
Contributor
Author
|
@JaewonHur ready for your ✅ again |
Contributor
|
Looks like some conflicts with main..? |
saehejkang
force-pushed
the
add-init-decoder-for-attachment-and-network-config
branch
from
44f7cce to
1389b63
Compare
Co-authored-by: Ed Saipetch <ed@twentybelow.com>
saehejkang
force-pushed
the
add-init-decoder-for-attachment-and-network-config
branch
from
1389b63 to
0c125a6
Compare
Contributor
Author
should be fixed now I think |
Contributor
Author
|
@JaewonHur bump 😄 |
JaewonHur
approved these changes
Mar 16, 2026
JaewonHur
reviewed
Mar 16, 2026
| case macAddress | ||
| // TODO: retain for deserialization compatibility for now, remove later | ||
| case address | ||
| case gateway |
Contributor
There was a problem hiding this comment.
Sorry for the delay.
Seems mtu field is added.
Let me approve and merge it once it is done!
Contributor
Author
There was a problem hiding this comment.
I just pushed the changes that should fix the ci issues. Completely forgot about the mtu field that was just added.
JaewonHur
approved these changes
Mar 17, 2026
|
Appreciate it |
saehejkang
deleted the
add-init-decoder-for-attachment-and-network-config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Adds backward-compatible JSON decoding/encoding fallback for
AttachmentandNetworkStatusto preventkeyNotFounderrors when communicating with oldercontainer-apiserverversions.Temporary fix but closes #1196
Testing
Tests ✅ based on comment here