Open
Conversation
Signed-off-by: Aditya Ramani <a_ramani@apple.com>
adityaramani
force-pushed
the
chunked-write
branch
from
4979b78 to
4273394
Compare
dcantah
reviewed
Mar 18, 2026
| try self.writeHeader(entry: entry) | ||
| let chunkSize = 4 * 1024 * 1024 | ||
| while true { | ||
| let chunk = fileHandle.readData(ofLength: chunkSize) |
Member
There was a problem hiding this comment.
Can we just have a preallocated scratch buffer in our writer of size chunkSize that we fill, and use read(2) directly. I have a vendetta against fileHandle readData LOL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in ArchiveWriter where large files would only partly be written into an archive.
This is done so by writing the data in chunks.