Open
Conversation
- Introduced BotDetection struct to manage bot detection settings. - Implemented GetBotDetection and UpdateBotDetection methods for retrieving and updating bot detection configurations. - Added corresponding test cases for bot detection settings in attack_protection_test.go and management.gen_test.go. - Enhanced management.gen.go with getter methods for BotDetection fields to improve data access.
…tection signatures - Removed unnecessary line breaks in the function signatures for GetBotDetection and UpdateBotDetection. - Improved code readability and consistency by aligning function parameters. - No functional changes were made; this is purely a formatting improvement.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1 #698 +/- ##
==========================================
+ Coverage 96.74% 96.75% +0.01%
==========================================
Files 62 62
Lines 10818 10862 +44
==========================================
+ Hits 10466 10510 +44
Misses 234 234
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bot detection management to the
AttackProtectionManager.🔧 Changes
New Type:
BotDetection- Manages bot detection settings including detection level, challenge policies, IP allowlist, and monitoring modeNew Methods:
GetBotDetection()- Retrieves current bot detection settingsUpdateBotDetection()- Updates bot detection configuration📚 References
🔬 Testing
Automated Tests:
GetBotDetectionandUpdateBotDetectionmethods inmanagement/attack_protection_test.gomanagement/management.gen_test.go📝 Checklist