Skip to content

Use inlineLarge toolbar title display mode#1

Merged
ertembiyik merged 1 commit intomainfrom
codex/use-inlinelarge-for-toolbar-titles
Sep 27, 2025
Merged

Use inlineLarge toolbar title display mode#1
ertembiyik merged 1 commit intomainfrom
codex/use-inlinelarge-for-toolbar-titles

Conversation

@ertembiyik
Copy link
Contributor

@ertembiyik ertembiyik commented Sep 24, 2025

Summary

  • apply the new inlineLarge toolbar title display mode to the agents and custom models list screens so they stop using large titles

Testing

  • swiftlint ./Bluerage/ --strict (fails: command not found)

https://chatgpt.com/codex/tasks/task_e_68d47bdbcc788331bdaa962f0d282901

Summary by CodeRabbit

  • Style
    • Updated toolbar title presentation on the Agents list and Custom Models list screens to use an inline large style.
    • Users will notice a larger, inline title with adjusted spacing and visual hierarchy within the navigation bar.
    • Only the title’s rendering is affected; navigation actions and other toolbar items remain unchanged.
    • No impact on data, performance, or behavior of the lists beyond the visual adjustment to the title area.

@coderabbitai
Copy link

coderabbitai bot commented Sep 24, 2025

Walkthrough

Applied the SwiftUI modifier toolbarTitleDisplayMode(.inlineLarge) to two list screen views, adjusting the navigation title presentation. No changes to data flow, logic, or public APIs.

Changes

Cohort / File(s) Summary of edits
Toolbar title display mode update
Bluerage/Sources/UI/Screens/Agents/AgentsList/AgentsListScreenView.swift, Bluerage/Sources/UI/Screens/CustomModels/CustomModelsList/CustomModelsListScreenView.swift
Added toolbarTitleDisplayMode(.inlineLarge) to alter navigation title display style; no control-flow or data changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I nudged the titles, small and spry,
Inline-large beneath the sky.
Two lists gleam with tidy grace—
hop, hop—new polish in their place.
Ears up, I ship with gentle pride,
UI carrots neatly aligned. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the primary change of applying the inlineLarge toolbar title display mode, matching the modifications in both screen view files. It is concise, clear, and focused on the main change without extraneous detail. Reviewers can immediately understand the intent and scope of the pull request from the title alone.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/use-inlinelarge-for-toolbar-titles

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0538bc3 and c00d307.

📒 Files selected for processing (2)
  • Bluerage/Sources/UI/Screens/Agents/AgentsList/AgentsListScreenView.swift (1 hunks)
  • Bluerage/Sources/UI/Screens/CustomModels/CustomModelsList/CustomModelsListScreenView.swift (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Lint & Format
Bluerage/Sources/UI/Screens/CustomModels/CustomModelsList/CustomModelsListScreenView.swift

[error] 96-96: Line Length Violation: Line should be 120 characters or less; currently 125 characters


[error] 108-108: Line Length Violation: Line should be 120 characters or less; currently 122 characters

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Generate and Check Licenses

Comment on lines +62 to 63
.toolbarTitleDisplayMode(.inlineLarge)
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Guard inlineLarge behind an iOS 18 availability check.

ToolbarTitleDisplayMode.inlineLarge is only available starting iOS 18. Without an availability gate, we’ll fail to build (or crash at runtime if we bump the deployment target later) on any deployment target < 18. Please add a fallback—.inline keeps the intent intact for older OS versions.

Apply this diff to reuse the mode everywhere in the view:

-                .toolbarTitleDisplayMode(.inlineLarge)
+                .toolbarTitleDisplayMode(self.toolbarTitleDisplayMode)

Add this helper inside AgentsListScreenView:

private var toolbarTitleDisplayMode: ToolbarTitleDisplayMode {
    if #available(iOS 18.0, *) {
        return .inlineLarge
    } else {
        return .inline
    }
}
🤖 Prompt for AI Agents
In Bluerage/Sources/UI/Screens/Agents/AgentsList/AgentsListScreenView.swift
around lines 62–63 the code uses ToolbarTitleDisplayMode.inlineLarge which is
only available on iOS 18+, so add an availability-safe helper property inside
AgentsListScreenView that returns .inlineLarge when #available(iOS 18.0, *) and
.inline otherwise, and replace the direct .toolbarTitleDisplayMode(.inlineLarge)
call with .toolbarTitleDisplayMode(toolbarTitleDisplayMode) so older deployment
targets compile and behave correctly.

Comment on lines +54 to 55
.toolbarTitleDisplayMode(.inlineLarge)
.background(UIColor.systemGroupedBackground.swiftUI)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Match the availability guard for inlineLarge.

Same concern here: .inlineLarge requires iOS 18+, so we need the same guard/fallback as the agents list to keep the build green on earlier iOS versions.

-            .toolbarTitleDisplayMode(.inlineLarge)
+            .toolbarTitleDisplayMode(self.toolbarTitleDisplayMode)

Add alongside the other helpers in this view:

private var toolbarTitleDisplayMode: ToolbarTitleDisplayMode {
    if #available(iOS 18.0, *) {
        return .inlineLarge
    } else {
        return .inline
    }
}
🤖 Prompt for AI Agents
In
Bluerage/Sources/UI/Screens/CustomModels/CustomModelsList/CustomModelsListScreenView.swift
around lines 54–55, the view uses .toolbarTitleDisplayMode(.inlineLarge) which
requires iOS 18+, so add a private computed helper property (near the other
helpers in this view) that returns .inlineLarge when #available(iOS 18.0, *) and
.inline otherwise, then replace the direct
.toolbarTitleDisplayMode(.inlineLarge) call with
.toolbarTitleDisplayMode(toolbarTitleDisplayMode) to provide the
availability-safe fallback.

@ertembiyik ertembiyik merged commit c096896 into main Sep 27, 2025
1 of 3 checks passed
@ertembiyik ertembiyik deleted the codex/use-inlinelarge-for-toolbar-titles branch September 27, 2025 15:14
ertembiyik added a commit that referenced this pull request Sep 27, 2025
…-toolbar-titles

Use inlineLarge toolbar title display mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant