Merged
Conversation
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
giltho
changed the title
@weigth attribute@weight attribute
jmid
reviewed
Feb 17, 2026
Collaborator
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
Thanks a bunch - this should indeed be documented!
I've made a few minor suggestions.
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
Contributor
Author
|
Sorry for the typo as well, bit sloppy not sure why I didn't catch it 😅 |
jmid
reviewed
Feb 18, 2026
Collaborator
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally forked the repo to create a
[@ignore]attribute to the PPX, and realised that the more general[@weight 0]was already implemented.PS: qcheck is really awesome!