Fix and extend PDO selection by record IDs (fixes #607)#632
Fix and extend PDO selection by record IDs (fixes #607)#632Roshan-Baghwar wants to merge 2 commits intocanopen-python:masterfrom
Conversation
|
Thank you for at least writing a description. Your "fix" is already fixed in latest master. It's very unfortunate that people keep providing "fixes" which actually remove good code because they are based on an older commit. That's useless. You know what's rude? Outlier is assessing your ability to provide guidance for AI bots to give better answers. The goal is for them to recruit you and pay you for this human input. But in the process, I am bothered with this crap and waste my time looking at it and giving guidance to you, which nobody wants to compensate for. Maybe you can give back a little by actually contributing fixes to the project. That's how open source works, not as an endless supply of code and people solely for AI miners to exploit. |
This PR corrects mixed up mapping parameter record index numbers, adds support for lookup by record IDs, and updates tests. Based on commit 593f062.