Skip to content

Fix and extend PDO selection by record IDs (fixes #607)#632

Closed
Roshan-Baghwar wants to merge 2 commits intocanopen-python:masterfrom
Roshan-Baghwar:pdo-fix-corrected
Closed

Fix and extend PDO selection by record IDs (fixes #607)#632
Roshan-Baghwar wants to merge 2 commits intocanopen-python:masterfrom
Roshan-Baghwar:pdo-fix-corrected

Conversation

@Roshan-Baghwar
Copy link

This PR corrects mixed up mapping parameter record index numbers, adds support for lookup by record IDs, and updates tests. Based on commit 593f062.

@acolomb
Copy link
Member

acolomb commented Mar 19, 2026

Thank you for at least writing a description. Your "fix" is already fixed in latest master. It's very unfortunate that people keep providing "fixes" which actually remove good code because they are based on an older commit. That's useless.

You know what's rude? Outlier is assessing your ability to provide guidance for AI bots to give better answers. The goal is for them to recruit you and pay you for this human input. But in the process, I am bothered with this crap and waste my time looking at it and giving guidance to you, which nobody wants to compensate for.

Maybe you can give back a little by actually contributing fixes to the project. That's how open source works, not as an endless supply of code and people solely for AI miners to exploit.

@acolomb acolomb closed this Mar 19, 2026
@Roshan-Baghwar Roshan-Baghwar deleted the pdo-fix-corrected branch March 19, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants