Add presets for compilation with v145 toolchain on windows#10
Merged
ccptoebeans merged 3 commits intocarbonengine:mainfrom Mar 10, 2026
Merged
Add presets for compilation with v145 toolchain on windows#10ccptoebeans merged 3 commits intocarbonengine:mainfrom
ccptoebeans merged 3 commits intocarbonengine:mainfrom
Conversation
Member
ccptoebeans
commented
Mar 9, 2026
ccptoebeans
commented
- Add presets to compile core with v145 of the MSVC toolchain.
- Upgrade carbonengine/vcpkg-registry submodule to get new triplet & toolchain files
CCP-Aporia
requested changes
Mar 9, 2026
CCP-Aporia
left a comment
CCP-Aporia
left a comment
There was a problem hiding this comment.
Instead of providing additional presets, let's just keep it simple and make v145 the default toolset on Windows. Otherwise, we end up with an endless explosion of changes here, additional TeamCity build pipelines, and so on. That's not what we want. We don't intend to keep support for v141 once we have upgraded to v145.
CCP-Aporia
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.