Skip to content

Do not show loading screen on hosted site#4257

Open
burieberry wants to merge 5 commits intomainfrom
cs-10399-host-mode-hide-loading-screen
Open

Do not show loading screen on hosted site#4257
burieberry wants to merge 5 commits intomainfrom
cs-10399-host-mode-hide-loading-screen

Conversation

@burieberry
Copy link
Copy Markdown
Contributor

@burieberry burieberry commented Mar 26, 2026

  • Do not show Loading... screen on hosted card
  • It will remain in operator-mode as usual
  • Fix for prerendered card scroll before css loads

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c41fe5b3ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions
Copy link
Copy Markdown

Preview deployments

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   2h 11m 31s ⏱️ +42s
2 061 tests ±0  2 046 ✅ ±0  15 💤 ±0  0 ❌ ±0 
2 076 runs  ±0  2 061 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit 4d0a899. ± Comparison against base commit 4d976c0.

♻️ This comment has been updated with latest results.

@burieberry burieberry force-pushed the cs-10399-host-mode-hide-loading-screen branch from 0a02377 to 4c15d17 Compare March 27, 2026 19:01
@burieberry burieberry requested a review from a team March 27, 2026 19:04
(await page.locator('[data-test-host-loading]').count()) === 0,
);

await page.locator('[data-test-host-mode-card-loaded').waitFor();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the missing ] here might make it pass?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. I had trouble getting playwright tests to run locally

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eep what was happening? I have trouble with many things but let me know if the mise changes seem related?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not quite sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants