This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Use COLUMNS environment variable for console width#14
Open
vadz wants to merge 1 commit intocatchorg:masterfrom
Open
Use COLUMNS environment variable for console width#14vadz wants to merge 1 commit intocatchorg:masterfrom
vadz wants to merge 1 commit intocatchorg:masterfrom
Conversation
If this variable is defined (which is not always the case but at least respecting it allows us to wrap things properly if it is), use it instead of the hard-coded 80 character line width. Closes catchorg#7.
Collaborator
|
Thanks for this. I'd like to use this PR at some point. So I just wanted to let you know that I'm not ignoring this in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this variable is defined (which is not always the case but at least
respecting it allows us to wrap things properly if it is), use it instead of
the hard-coded 80 character line width.
Closes #7.
Notice that I had to update
catch.hppas well because otherwise I was getting incomprehensible errors frommain.cppwhich usedTbc::TextAttributesfrom there and not fromclara.hitself. In fact, I think this points out a serious problem with the current stitching approach: it can easily result in ODR violations because the same stuff is stitched into bothcatch.hppandclara.h. To solve this you'd need to use unique namespaces for the internal stuff for the two headers.BTW, why does Clara use
.hextension when CATCH uses.hpp? Wouldn't it be better to use the latter for Clara too, if only for consistency?