bandwidthAbortRequestDuration fixes#78
Open
wiedehopf wants to merge 2 commits intocloudflare:mainfrom
Open
Conversation
…orted The abortTimeout is only canceled when the request is aborted. Also cancel it when the measurement is finished. retries == 0 is when the measurement is started, so when retries is set back to 0, the measurement is finished, add clearTimeout here. fixes: cloudflare#77
add check if abortController exists before calling .abort() this seems to be a race condition and i don't know the codebase well enough to really understand how it happens. but there should be no harm not aborting the request when there is no abortcontroller. fixes: cloudflare#77
Contributor
|
Please set a semver versioning label of either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bandwidthAbortRequestDuration: fix undefined dereference
bandwidthAbortRequestDuration: fix wrongly throwing error when not aborted
fixes: #77