[v8] RFC-0045: Stack management #3687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
Signed-off-by: Simon Jones <simonjones@vmware.com>
4 tasks
Signed-off-by: Simon Jones <simonjones@vmware.com>
vuil
reviewed
Jan 29, 2026
Contributor
vuil
left a comment
vuil
left a comment
There was a problem hiding this comment.
Thanks for the changes. I added a couple of minor suggestions. I assume this needs to wait till the cloud-controller changes are merged?
rashedkvm
reviewed
Jan 29, 2026
rashedkvm
left a comment
rashedkvm
left a comment
There was a problem hiding this comment.
Just a reminder to update the minimum API version prior to merging. Much appreciated!
vuil
reviewed
Feb 5, 2026
| fakeActor.GetStackByNameReturns(stack, v7action.Warnings{}, nil) | ||
| }) | ||
|
|
||
| It("Displays the stack information without state", func() { |
Contributor
There was a problem hiding this comment.
Thanks for addressing the comments here.
nit: it's odd I am not seeing the issue on the github page, but when I checked out the branch, it is showing this It("Displays... block is misindented by one fewer level. Same is true the next It(Displays.. block
Author
There was a problem hiding this comment.
I'm currently seeing correct indentation both locally and on the GH page
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Note: Please create separate PR for every branch (main and v8) as needed.
Description of the Change
This PR covers the CLI implementation details for RFC-0045: Enhance Stack Handling in Cloud Foundry. It adds an additional state field to output of the
cf stack,cf stacks&cf update-stackcommands, as well as adding the ability to modify the state to thecf update-stackcommand. This is a partner PR to the existing Cloud Controller changes submitted for reviewWhy Is This PR Valuable?
These changes will be required for consumers to interact with the new features available in the Cloud Controller, the RFC has been accepted, indicating the changes are valuable.
Applicable Issues
N/A
How Urgent Is The Change?
This should be accepted and released in line with the changes being proposed to the Cloud Controller
Other Relevant Parties
The Cloud Controller changes linked above should detail other people impacted.