refactor: hoist static values outside render loop#109
Open
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Open
refactor: hoist static values outside render loop#109TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
TrevorBurnham wants to merge 1 commit intocloudscape-design:mainfrom
Conversation
Move static computations out of the per-line render loop: - Hoist inline style objects to module scope constants - Pre-compute line number className at module level - Compute code line span className once before the loop For a 500-line code block, this eliminates ~1000 redundant clsx calls and prevents style object recreation on every render.
TrevorBurnham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the CodeView component by moving static computations out of the per-line render loop.
Problem
The
Children.maploop inInternalCodeViewwas computing values that don't change per-line:clsx(styles["line-number"], styles.unselectable)- called for every line, always returns the same stringclsx(codeElement.props.className, wrapLines ? ...)- called for every line, only depends onwrapLinesprop{ width: 1 }and{ width: "auto" }- recreated on every renderFor a code block with 500 lines, this means ~1000 unnecessary
clsxcalls per render.Solution
COL_STYLE_SHRINK,COL_STYLE_AUTO)lineNumberClassName)codeLineSpanClassName)Testing
Impact