Open
Conversation
jacobheun
previously approved these changes
Nov 16, 2023
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
Per discussions, project specific overrides in .taprc should do the trick.
Simon-Busch
reviewed
Nov 22, 2023
Comment on lines
-50
to
-53
| "tap": { | ||
| "coverage": true, | ||
| "ts": true | ||
| }, |
Contributor
There was a problem hiding this comment.
Does this somehow address the current 100% test coverage threshold expected ? ^^
Contributor
Author
There was a problem hiding this comment.
it does not. config has changed in the latest tap so these settings will cause it to throw an error. 100% coverage is the default now. if you need to lower the threshold you can create a .taprc file with
allow-incomplete-coverage: truei'll make sure the .gitignore template gets updated to keep .taprc files too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this builds on #8 so land that first
this update of tap does introduce some breaking changes, however it appears that most of them don't have any impact for us.
an upgrade guide exists here: https://node-tap.org/upgrading-from-16/
most notably, the
tapproperty needs to be removed from package.json. in some cases it may stay, but the format possibly changed. the new defaults for the settings that were previously in this skeleton are what we want to use.another significant change is that tap no longer uses istanbul for coverage, instead it uses c8. due to this, any lines of coverage that are skipped currently will need the comments skipping them to be updated to the c8 style of ignoring. this is documented here: https://github.com/bcoe/c8#ignoring-uncovered-lines-functions-and-blocks
THIS IS BLOCKED, DO NOT MERGE
see TypeStrong/ts-node#2009
once this lands, or another solution is arrived at, we can do this update. until then we can't since we should all be on node 18