Open
Conversation
| @@ -0,0 +1,26 @@ | |||
| Pull Request: | |||
Contributor
There was a problem hiding this comment.
We can the use .md extension in the Readme (e.g. Readme.md) so we can write in markdown the documentation.
| driver.find_element_by_id("password").send_keys(credentials['password']) | ||
| driver.find_element_by_id("_submit").click() | ||
|
|
||
| assert driver.find_element_by_id("private-sketches-counter").text=="0" |
Contributor
There was a problem hiding this comment.
Missing space between the comparison operator.
Also it maybe be better to just read the counters when you first visit the home page in order to get their initial state.
After creating / deleting sketches you can then check the counters values in order to test their behavior.
| actions.double_click(changeButton) | ||
| actions.perform() | ||
| self.get_element(By.ID, "logo_small").click() | ||
| assert driver.find_element_by_id("public-sketches-counter").text=="2" |
Contributor
|
Please be more descriptive in your commit messages. |
| self.get_element(By.ID, "save") | ||
| driver.find_element_by_id("logo_small").click() | ||
| #Check that the sketch was created | ||
| assert driver.find_element_by_id("public-sketches-counter").text=="1" |
added 8 commits
July 29, 2016 16:03
Checks that counters: Public sketches (blue) and Private sketches (purple) have the correct value (number of sketches of each category). Checks that the counter for private projects also appears at the Badges section and has the correct value. Checks that the number of private projects available is updated each time that you make a change (e.g from private to public and vice versa). Checks that the counter for available private sketches also appears at the upload sketch modal (ino, zip, multiple zip) and at the create sketch modal. Checks that All, Public and Private filters work.
00a8a1c to
1a058b5
Compare
added 15 commits
August 2, 2016 17:14
Check the description character counter is always in sync with the length of the short description. Check that when you enter a short description longer than 140 chars the character counter becomes red.
Tests that when a project is cloned in user's homepage message "Cloned from Sketch sketch_name by username" appears under the cloned project.
Test that when you create a sketch with short description, short description appears under sketch's title. Test that when a sketch is created, created message appears next to its title.
Check that share modal opens and you can click Embed tab. Check that you can swith back to Share tab inside share modal.
Tests that when a sketch is cloned, sketch opens in editor. Tests that in user's home page message Cloned from Sketch sketch_name by username appears under the cloned project.
Function now waits until x icon is clickable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homepage test cases:
upload sketchmodal (ino, zip, multiple zip) and at thecreateandeditsketch modal.create sketchmodal and try to create a new project without providing a name. TheCreatebutton should be disabled.Untitled Sketch CURRENT_DATE.All,PublicandPrivatebuttons work, clicking on each of them and verifying that the correct number of sketches is viewed each time.Cloned from Sketch sketch_name by usernameappears under the cloned project.Inside sketch block test cases:
Createbutton and go back to homepage. Sketch should sayCreatedinstead ofModified.Modifiedinstead ofCreated.Sharebutton. Click onSharebutton and check that it opens the share modal (titled "Share your Sketch").Clonebutton and check that the sketch is cloned and opens in editor.Deletebutton and check that the project is correctly deleted (it deletes the sketch and filelist is updated). Check that when the sketch is deleted the modal stays open showing the result of the deletion.Editor test cases:
private.public.Clonebutton. You should get redirected to a new editor, check the name ("copy").