Open
Conversation
Signed-off-by: DL6ER <dl6er@dl6er.de>
3a601c8 to
d68486a
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
d68486a to
ad92336
Compare
Owner
|
Hi @DL6ER . Thank you for your contribution. So far, the API of this library was more like a "hidden feature". While I planned to provide an official API at some point, I didn't want to do that before I've done some major refactoring as I wanted the API to be more stable. Unfortunately, I'm rather busy with my job at the moment, but I'll have a closer look at this PR once I've got a bit more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using
openapi-example-validatorto check if the values returned by our API meet the specifications. This to ensure we cannot forget to update the documentation and to avoid any breaking changes in API output.Currently, the code does not support much external interaction, e.g., it expects external examples to be present as files. After this PR, we expose two more functions, that may be used by an external script like (fully working example):
Output is:
I also added tests for the two new functions.
Please mind that this is my very first attempt at anything
node-related. I'm happy to improve something if I missed some things.