Open
Conversation
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
mux-bot
bot
force-pushed
the
auto-cleanup
branch
3 times, most recently
from
ed81868 to
fd4a961
Compare
These two type aliases in global.d.ts were never imported or referenced anywhere in the codebase. They appear to be remnants of an earlier permission system design that was superseded.
The status_set tool was removed in 9ef71ed (derive workspace status from todo list), but its STATUS_MESSAGE_MAX_LENGTH constant was left behind with zero remaining consumers.
…helper Both agentDefinitionsService and agentSkillsService duplicated the same shouldUseHostGlobalMuxFallback → LocalRuntime fallback pattern with identical comments. Extract a shared resolveGlobalRuntime() function in hostGlobalMuxHome.ts and use it from both services, removing the per-service LocalRuntime imports and inline logic.
deriveQueuedPreview is only used within QueuedMessage.tsx itself. Removing the export keyword keeps the module surface minimal.
…rJsonCommand listAgentBrowserSessionNames had its own spawn+timeout+collect+JSON-parse loop identical to the generic runAgentBrowserJsonCommand helper introduced in the same file. Rewrite it as a thin wrapper that calls the helper and extracts session names from the result. Removes ~65 lines of duplicated process-management code with no behavior change.
mux-bot
bot
force-pushed
the
auto-cleanup
branch
from
fd4a961 to
0db4f5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Periodic auto-cleanup PR. Each commit is an independent,
behavior-preserving refactor found by scanning recent
maincommits.Current cleanups
Extract
resolveGlobalRuntimeinto shared helper — BothagentDefinitionsServiceandagentSkillsServiceduplicated the sameshouldUseHostGlobalMuxFallback → LocalRuntimefallback pattern. Extracted a sharedresolveGlobalRuntime()function inhostGlobalMuxHome.ts.Remove dead
UIPermissionModeandSDKPermissionModetype aliases —These two exported type aliases in
src/common/types/global.d.tswerenever imported or referenced anywhere in the codebase. Removing the unused
types and their comments.
Remove unused export from
deriveQueuedPreview—deriveQueuedPreviewinQueuedMessage.tsxwas exported but only usedwithin the same file. Removed the
exportkeyword to keep the modulesurface minimal.
Validation
make static-check(ESLint, TypeScript, Prettier all pass)Auto-cleanup checkpoint: e7efeab
Generated with
mux• Model:anthropic:claude-opus-4-6• Thinking:xhigh• Cost:N/A