Skip to content

chore: bump requests-oauthlib to v2#2492

Open
dmivankov wants to merge 1 commit intomasterfrom
requests_oauthlib_v2
Open

chore: bump requests-oauthlib to v2#2492
dmivankov wants to merge 1 commit intomasterfrom
requests_oauthlib_v2

Conversation

@dmivankov
Copy link
Contributor

@dmivankov dmivankov self-assigned this Feb 26, 2026
@dmivankov dmivankov force-pushed the requests_oauthlib_v2 branch from 949496a to d716898 Compare February 26, 2026 10:33
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.86%. Comparing base (6c02aac) to head (bafef42).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2492      +/-   ##
==========================================
- Coverage   48.86%   48.86%   -0.01%     
==========================================
  Files         191      191              
  Lines       26162    26162              
==========================================
- Hits        12784    12783       -1     
- Misses      13378    13379       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmivankov dmivankov marked this pull request as ready for review February 26, 2026 10:58
@dmivankov dmivankov requested review from a team as code owners February 26, 2026 10:58
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dmivankov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the requests-oauthlib dependency to its latest major version, 2.0.0. This upgrade ensures the project leverages the most recent features, bug fixes, and security enhancements provided by the library, maintaining compatibility with modern Python environments.

Highlights

  • Dependency Update: The requests-oauthlib library has been upgraded from version 1.3.1 to 2.0.0.
  • Python Compatibility: The updated requests-oauthlib now specifies a minimum Python version of 3.4, which is compatible with the project's ^3.10 requirement.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • poetry.lock
    • Updated the requests-oauthlib package entry to version 2.0.0.
    • Modified the python-versions constraint for requests-oauthlib to >=3.4.
    • Updated the file hashes for the new requests-oauthlib version.
    • Updated the overall content-hash of the lock file.
  • pyproject.toml
    • Adjusted the requests_oauthlib dependency specification to ^2, allowing for the new major version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades requests-oauthlib to version 2.0.0. The main breaking change in this new major version is that OAuth2Session.fetch_token now consistently raises an OAuth2Error on failure instead of sometimes returning None. I've verified that the SDK's usage of this method in OAuthClientCredentials already handles this exception correctly, making the upgrade safe. The changes to pyproject.toml and poetry.lock are correct for this dependency bump.

@haakonvt
Copy link
Contributor

@dmivankov are there CVEs or other reasons to drop v1? If not, lets go with >=1, <3

@dmivankov
Copy link
Contributor Author

@dmivankov are there CVEs or other reasons to drop v1? If not, lets go with >=1, <3

I was building cognite-sdk for NixOS (as it is not packaged to nixpkgs right now), and there lib version is v2
>=1, <3 sounds good to me 👍

@dmivankov dmivankov force-pushed the requests_oauthlib_v2 branch from d38e1c2 to bafef42 Compare February 26, 2026 12:49
Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for noticing & making a PR 👌

@haakonvt haakonvt added the waiting-for-risk-review Waiting for a member of the risk review team to take an action label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-risk-review Waiting for a member of the risk review team to take an action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants