Open
Conversation
Adjusted wheelbase and tirestiffnessFactor to values that have been under test on my 2020 Yukon for about 10 months & 6680+ miles dongle id 2dced94c58d236. Device failed and future routes will be on dongle id a843568dc5f36ae3
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 20 segments for: GMC_ACADIA, GMC_YUKON Show changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted wheelbase and tirestiffnessFactor to values that have been under test on my 2020 Yukon for about 10 months & 6680+ miles dongle id 2dced94c58d236. Device failed and future routes will be on dongle id a843568dc5f36ae3
Validation
I cannot access more recent routes from my original device, but if needed can upload more routes from the new device in a few days