HKG: add KIA_SPORTAGE_5TH_GEN (NQ5) to CANFD_FUZZY_WHITELIST#3161
HKG: add KIA_SPORTAGE_5TH_GEN (NQ5) to CANFD_FUZZY_WHITELIST#3161syrull wants to merge 1 commit intocommaai:masterfrom
Conversation
The NQ5 Sportage is a CAN-FD car that is blacklisted from fuzzy fingerprinting. Cars with firmware versions not in the exact database cannot be matched at all. Both ICE and Hybrid share the same platform (KIA_SPORTAGE_5TH_GEN) and platform code (NQ5), so fuzzy matching is safe.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
Car behavior reportReplays driving segments through this PR and compares the behavior to master. Testing 260 segments for: HYUNDAI_AZERA_HEV_6TH_GEN, HYUNDAI_ELANTRA_GT_I30, HYUNDAI_ELANTRA_2021, HYUNDAI_ELANTRA_HEV_2021, HYUNDAI_GENESIS, HYUNDAI_IONIQ, HYUNDAI_IONIQ_HEV_2022, HYUNDAI_IONIQ_EV_2020, HYUNDAI_IONIQ_PHEV_2019, HYUNDAI_IONIQ_PHEV, HYUNDAI_KONA_2022, HYUNDAI_KONA_EV, HYUNDAI_KONA_EV_2022, HYUNDAI_KONA_EV_2ND_GEN, HYUNDAI_SANTA_FE, HYUNDAI_SANTA_FE_2022, HYUNDAI_SANTA_FE_HEV_2022, HYUNDAI_SANTA_FE_PHEV_2022, HYUNDAI_SONATA, HYUNDAI_SONATA_LF, HYUNDAI_STARIA_4TH_GEN, HYUNDAI_PALISADE, HYUNDAI_SONATA_HYBRID, HYUNDAI_IONIQ_5, HYUNDAI_IONIQ_6, HYUNDAI_TUCSON_4TH_GEN, HYUNDAI_SANTA_CRUZ_1ST_GEN, HYUNDAI_CUSTIN_1ST_GEN ✅ 0 changed, 260 passed, 0 errors |
1 participant
Description
Adds
CAR.KIA_SPORTAGE_5TH_GENtoCANFD_FUZZY_WHITELISTinopendbc/car/hyundai/values.py.Problem
The KIA Sportage 5th Gen (NQ5) is a CAN-FD car that is currently blacklisted from fuzzy fingerprinting. Cars with firmware versions not present in the exact fingerprint database cannot be matched at all — both exact and fuzzy matching fail, resulting in "unsupported car" on the device.
Fix
Adding the NQ5 to
CANFD_FUZZY_WHITELISTenables platform code-based fuzzy matching. This is safe because:KIA_SPORTAGE_5TH_GEN) and platform code (NQ5)Testing
Tested on a KIA NQ5 Sportage that was previously showing as unsupported.