ui: fix false "NO PANDA" flash on screen wake#37404
Open
andiradulescu wants to merge 2 commits intocommaai:masterfrom
Open
ui: fix false "NO PANDA" flash on screen wake#37404andiradulescu wants to merge 2 commits intocommaai:masterfrom
andiradulescu wants to merge 2 commits intocommaai:masterfrom
Conversation
Contributor
UI Previewmici: Videos are identical! View Diff Report |
sshane
reviewed
Feb 25, 2026
selfdrive/ui/ui_state.py
Outdated
| if self.panda_type != log.PandaState.PandaType.unknown: | ||
| self.ignition = any(state.ignitionLine or state.ignitionCan for state in panda_states) | ||
| elif self.sm.frame - self.sm.recv_frame["pandaStates"] > 5 * rl.get_fps(): | ||
| elif self.sm.frame - self.sm.recv_frame["pandaStates"] > 5 * gui_app.target_fps: |
Contributor
There was a problem hiding this comment.
what are the ramifications if we switch to recv_time? easy to keep it deterministic in the ui diff tool?
Contributor
Author
There was a problem hiding this comment.
don't see any ramifications, pushed the change now
as for the ui diff tool, the elif branch is dead code during replay, since pandaStates messages are sent continuously
as for being deterministic, in theoretical sense it wasn't deterministic before and it's not deterministic now, since neither rl.get_fps() nor time.monotonic() are overriden in replay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the annoying issue when sometimes tapping on the screen to wake it up, "NO PANDA" is shown for a split second