refactor: move ApiServer&ApiHandler to cpp file and overwrite config …#394
Merged
BigVan merged 1 commit intocontainerd:dev/snapshotfrom Mar 16, 2026
Merged
refactor: move ApiServer&ApiHandler to cpp file and overwrite config …#394BigVan merged 1 commit intocontainerd:dev/snapshotfrom
BigVan merged 1 commit intocontainerd:dev/snapshotfrom
Conversation
…after creating snapshot per review Signed-off-by: Xun Chen <xunchen@hust.edu.cn>
BigVan
reviewed
Mar 16, 2026
| api_handler.reset(new ApiHandler(this)); | ||
| api_server = new ApiServer(global_conf.serviceConfig().address(), api_handler.get()); | ||
| if(!api_server->ready) | ||
| auto ret = start_api_server(api_server, this, global_conf.serviceConfig().address()); |
Member
There was a problem hiding this comment.
need 'delete ret' if init() fails?
| LOG_ERRNO_RETURN(0, -1, "new localfs_adaptor failed"); | ||
| } | ||
| DEFER(delete lfs); | ||
| lfs->rename(new_config_path, this->config_path.c_str()); |
Member
There was a problem hiding this comment.
check return value... print an error log at least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…after creating snapshot per review
What this PR does / why we need it:
Make the following adjustment according to the code review:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: